mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

i2o: cleanup some exit paths 

This is just a cleanup and doesn't change how the code works.

The original code had a mix of returns and gotos so I changed everything
to just return directly.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Dan Carpenter 2010-04-23 22:19:13 +02:00 committed by Jiri Kosina
parent a33f32244d
commit b1ffdc8f3d
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/message/i2o/i2o_config.c
View File

@ -314,22 +314,22 @@ static int i2o_cfg_swul(unsigned long arg)
int ret = 0;
if (copy_from_user(&kxfer, pxfer, sizeof(struct i2o_sw_xfer)))
goto return_fault;
return -EFAULT;
if (get_user(swlen, kxfer.swlen) < 0)
goto return_fault;
return -EFAULT;
if (get_user(maxfrag, kxfer.maxfrag) < 0)
goto return_fault;
return -EFAULT;
if (get_user(curfrag, kxfer.curfrag) < 0)
goto return_fault;
return -EFAULT;
if (curfrag == maxfrag)
fragsize = swlen - (maxfrag - 1) * 8192;
if (!kxfer.buf)
goto return_fault;
return -EFAULT;
c = i2o_find_iop(kxfer.iop);
if (!c)
@ -373,12 +373,8 @@ static int i2o_cfg_swul(unsigned long arg)
i2o_dma_free(&c->pdev->dev, &buffer);
return_ret:
return ret;
return_fault:
ret = -EFAULT;
goto return_ret;
};
}
static int i2o_cfg_swdel(unsigned long arg)
{