mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 14:44:12 +00:00
signal/pid_namespace: Fix reboot_pid_ns to use send_sig not force_sig
[ Upstream commitf9070dc945
] The locking in force_sig_info is not prepared to deal with a task that exits or execs (as sighand may change). The is not a locking problem in force_sig as force_sig is only built to handle synchronous exceptions. Further the function force_sig_info changes the signal state if the signal is ignored, or blocked or if SIGNAL_UNKILLABLE will prevent the delivery of the signal. The signal SIGKILL can not be ignored and can not be blocked and SIGNAL_UNKILLABLE won't prevent it from being delivered. So using force_sig rather than send_sig for SIGKILL is confusing and pointless. Because it won't impact the sending of the signal and and because using force_sig is wrong, replace force_sig with send_sig. Cc: Daniel Lezcano <daniel.lezcano@free.fr> Cc: Serge Hallyn <serge@hallyn.com> Cc: Oleg Nesterov <oleg@redhat.com> Fixes:cf3f89214e
("pidns: add reboot_pid_ns() to handle the reboot syscall") Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
1c8e736115
commit
b397462a01
1 changed files with 1 additions and 1 deletions
|
@ -325,7 +325,7 @@ int reboot_pid_ns(struct pid_namespace *pid_ns, int cmd)
|
|||
}
|
||||
|
||||
read_lock(&tasklist_lock);
|
||||
force_sig(SIGKILL, pid_ns->child_reaper);
|
||||
send_sig(SIGKILL, pid_ns->child_reaper, 1);
|
||||
read_unlock(&tasklist_lock);
|
||||
|
||||
do_exit(0);
|
||||
|
|
Loading…
Reference in a new issue