From b410e35dbfedcb24b74f736d69b5b6337f9eb9ba Mon Sep 17 00:00:00 2001 From: Lee Jones Date: Wed, 4 Nov 2020 19:35:31 +0000 Subject: [PATCH] tty: n_gsm: Demote obvious abuse of kernel-doc and supply other missing docss Fixes the following W=1 kernel build warning(s): drivers/tty/n_gsm.c:85: warning: Function parameter or member 'ref' not described in 'gsm_mux_net' drivers/tty/n_gsm.c:85: warning: Function parameter or member 'dlci' not described in 'gsm_mux_net' drivers/tty/n_gsm.c:664: warning: Function parameter or member 'dlci' not described in 'gsm_data_kick' drivers/tty/n_gsm.c:1015: warning: Function parameter or member 'clen' not described in 'gsm_process_modem' Cc: Greg Kroah-Hartman Cc: Jiri Slaby Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20201104193549.4026187-19-lee.jones@linaro.org Signed-off-by: Greg Kroah-Hartman --- drivers/tty/n_gsm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 25f3152089c2..c676fa89ee0b 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -74,7 +74,7 @@ module_param(debug, int, 0600); #define MAX_MTU 1500 #define GSM_NET_TX_TIMEOUT (HZ*10) -/** +/* * struct gsm_mux_net - network interface * * Created when net interface is initialized. @@ -651,6 +651,7 @@ static struct gsm_msg *gsm_data_alloc(struct gsm_mux *gsm, u8 addr, int len, /** * gsm_data_kick - poke the queue * @gsm: GSM Mux + * @dlci: DLCI sending the data * * The tty device has called us to indicate that room has appeared in * the transmit queue. Ram more data into the pipe if we have any @@ -1005,6 +1006,7 @@ static void gsm_control_reply(struct gsm_mux *gsm, int cmd, const u8 *data, * @tty: virtual tty bound to the DLCI * @dlci: DLCI to affect * @modem: modem bits (full EA) + * @clen: command length * * Used when a modem control message or line state inline in adaption * layer 2 is processed. Sort out the local modem state and throttles