mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 21:33:52 +00:00
xfrm: Avoid clang fortify warning in copy_to_user_tmpl()
commit 1a807e46aa
upstream.
After a couple recent changes in LLVM, there is a warning (or error with
CONFIG_WERROR=y or W=e) from the compile time fortify source routines,
specifically the memset() in copy_to_user_tmpl().
In file included from net/xfrm/xfrm_user.c:14:
...
include/linux/fortify-string.h:438:4: error: call to '__write_overflow_field' declared with 'warning' attribute: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror,-Wattribute-warning]
438 | __write_overflow_field(p_size_field, size);
| ^
1 error generated.
While ->xfrm_nr has been validated against XFRM_MAX_DEPTH when its value
is first assigned in copy_templates() by calling validate_tmpl() first
(so there should not be any issue in practice), LLVM/clang cannot really
deduce that across the boundaries of these functions. Without that
knowledge, it cannot assume that the loop stops before i is greater than
XFRM_MAX_DEPTH, which would indeed result a stack buffer overflow in the
memset().
To make the bounds of ->xfrm_nr clear to the compiler and add additional
defense in case copy_to_user_tmpl() is ever used in a path where
->xfrm_nr has not been properly validated against XFRM_MAX_DEPTH first,
add an explicit bound check and early return, which clears up the
warning.
Cc: stable@vger.kernel.org
Link: https://github.com/ClangBuiltLinux/linux/issues/1985
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
dc60b25540
commit
b475226733
1 changed files with 3 additions and 0 deletions
|
@ -2017,6 +2017,9 @@ static int copy_to_user_tmpl(struct xfrm_policy *xp, struct sk_buff *skb)
|
||||||
if (xp->xfrm_nr == 0)
|
if (xp->xfrm_nr == 0)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
if (xp->xfrm_nr > XFRM_MAX_DEPTH)
|
||||||
|
return -ENOBUFS;
|
||||||
|
|
||||||
for (i = 0; i < xp->xfrm_nr; i++) {
|
for (i = 0; i < xp->xfrm_nr; i++) {
|
||||||
struct xfrm_user_tmpl *up = &vec[i];
|
struct xfrm_user_tmpl *up = &vec[i];
|
||||||
struct xfrm_tmpl *kp = &xp->xfrm_vec[i];
|
struct xfrm_tmpl *kp = &xp->xfrm_vec[i];
|
||||||
|
|
Loading…
Reference in a new issue