mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
st: use noop_llseek() instead of default_llseek()
st_open() suggests that llseek() doesn't work: "We really want to do nonseekable_open(inode, filp); here, but some versions of tar incorrectly call lseek on tapes and bail out if that fails. So we disallow pread() and pwrite(), but permit lseeks." Instead of using the fallback default_llseek() the driver should use noop_llseek() which leaves the file->f_pos untouched but succeeds. Signed-off-by: Jan Blunck <jblunck@suse.de> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Kai Makisara <Kai.Makisara@kolumbus.fi> Cc: Willem Riede <osst@riede.org> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
889e5fbbc2
commit
b4d878e23c
1 changed files with 1 additions and 0 deletions
|
@ -3962,6 +3962,7 @@ static const struct file_operations st_fops =
|
||||||
.open = st_open,
|
.open = st_open,
|
||||||
.flush = st_flush,
|
.flush = st_flush,
|
||||||
.release = st_release,
|
.release = st_release,
|
||||||
|
.llseek = noop_llseek,
|
||||||
};
|
};
|
||||||
|
|
||||||
static int st_probe(struct device *dev)
|
static int st_probe(struct device *dev)
|
||||||
|
|
Loading…
Reference in a new issue