mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 21:33:52 +00:00
staging: rtl8192e: Fix use after free in _rtl92e_pci_disconnect()
The free_rtllib() function frees the "dev" pointer so there is use
after free on the next line. Re-arrange things to avoid that.
Fixes: 66898177e7
("staging: rtl8192e: Fix unload/reload problem")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211117072016.GA5237@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
ffcf7ae90f
commit
b535917c51
1 changed files with 2 additions and 1 deletions
|
@ -2549,13 +2549,14 @@ static void _rtl92e_pci_disconnect(struct pci_dev *pdev)
|
||||||
free_irq(dev->irq, dev);
|
free_irq(dev->irq, dev);
|
||||||
priv->irq = 0;
|
priv->irq = 0;
|
||||||
}
|
}
|
||||||
free_rtllib(dev);
|
|
||||||
|
|
||||||
if (dev->mem_start != 0) {
|
if (dev->mem_start != 0) {
|
||||||
iounmap((void __iomem *)dev->mem_start);
|
iounmap((void __iomem *)dev->mem_start);
|
||||||
release_mem_region(pci_resource_start(pdev, 1),
|
release_mem_region(pci_resource_start(pdev, 1),
|
||||||
pci_resource_len(pdev, 1));
|
pci_resource_len(pdev, 1));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
free_rtllib(dev);
|
||||||
}
|
}
|
||||||
|
|
||||||
pci_disable_device(pdev);
|
pci_disable_device(pdev);
|
||||||
|
|
Loading…
Reference in a new issue