mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
seq_file: fix passing wrong private data
[ Upstream commit10a6de19ca
] DEFINE_PROC_SHOW_ATTRIBUTE() is supposed to be used to define a series of functions and variables to register proc file easily. And the users can use proc_create_data() to pass their own private data and get it via seq->private in the callback. Unfortunately, the proc file system use PDE_DATA() to get private data instead of inode->i_private. So fix it. Fortunately, there only one user of it which does not pass any private data, so this bug does not break any in-tree codes. Link: https://lkml.kernel.org/r/20211029032638.84884-1-songmuchun@bytedance.com Fixes:97a32539b9
("proc: convert everything to "struct proc_ops"") Signed-off-by: Muchun Song <songmuchun@bytedance.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Florent Revest <revest@chromium.org> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
4af0cd17e7
commit
b5703462a4
1 changed files with 1 additions and 1 deletions
|
@ -182,7 +182,7 @@ static const struct file_operations __name ## _fops = { \
|
||||||
#define DEFINE_PROC_SHOW_ATTRIBUTE(__name) \
|
#define DEFINE_PROC_SHOW_ATTRIBUTE(__name) \
|
||||||
static int __name ## _open(struct inode *inode, struct file *file) \
|
static int __name ## _open(struct inode *inode, struct file *file) \
|
||||||
{ \
|
{ \
|
||||||
return single_open(file, __name ## _show, inode->i_private); \
|
return single_open(file, __name ## _show, PDE_DATA(inode)); \
|
||||||
} \
|
} \
|
||||||
\
|
\
|
||||||
static const struct proc_ops __name ## _proc_ops = { \
|
static const struct proc_ops __name ## _proc_ops = { \
|
||||||
|
|
Loading…
Reference in a new issue