mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 14:14:37 +00:00
8250_men_mcb: Fix unsigned expression compared with zero
There is a warning reported by coccinelle:
./drivers/tty/serial/8250/8250_men_mcb.c:226:6-19: WARNING:
Unsigned expression compared with zero: data -> line [ i ] < 0
The array "line" of serial_8250_men_mcb_data is used to record the
registered serial port. When register a port failed, it will return
an error code, but the type of "line" is "unsigned int", causing
the error code to reverse. Modify the type of "data -> line" to solve
this problem.
Fixes: 2554e6ba28
("8250_men_mcb: Read num ports from register data.")
Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230803142053.1308926-1-lizetao1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
4b37932f78
commit
b58168698c
1 changed files with 1 additions and 1 deletions
|
@ -46,7 +46,7 @@
|
|||
|
||||
struct serial_8250_men_mcb_data {
|
||||
int num_ports;
|
||||
unsigned int line[MAX_PORTS];
|
||||
int line[MAX_PORTS];
|
||||
unsigned int offset[MAX_PORTS];
|
||||
};
|
||||
|
||||
|
|
Loading…
Reference in a new issue