mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-22 18:41:06 +00:00
selftests/powerpc: Fix resource leaks
[ Upstream commit8f4ab7da90
] In check_all_cpu_dscr_defaults, opendir() opens the directory stream. Add missing closedir() in the error path to release it. In check_cpu_dscr_default, open() creates an open file descriptor. Add missing close() in the error path to release it. Fixes:ebd5858c90
("selftests/powerpc: Add test for all DSCR sysfs interfaces") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20221205084429.570654-1-linmq006@gmail.com Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
01e3641b16
commit
b5dd27890c
1 changed files with 4 additions and 1 deletions
|
@ -24,6 +24,7 @@ static int check_cpu_dscr_default(char *file, unsigned long val)
|
|||
rc = read(fd, buf, sizeof(buf));
|
||||
if (rc == -1) {
|
||||
perror("read() failed");
|
||||
close(fd);
|
||||
return 1;
|
||||
}
|
||||
close(fd);
|
||||
|
@ -65,8 +66,10 @@ static int check_all_cpu_dscr_defaults(unsigned long val)
|
|||
if (access(file, F_OK))
|
||||
continue;
|
||||
|
||||
if (check_cpu_dscr_default(file, val))
|
||||
if (check_cpu_dscr_default(file, val)) {
|
||||
closedir(sysfs);
|
||||
return 1;
|
||||
}
|
||||
}
|
||||
closedir(sysfs);
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue