mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 13:22:57 +00:00
fs/proc/proc_sysctl.c: fix potential page fault while unregistering sysctl table
[ Upstream commita0b0d1c345
] proc_sys_link_fill_cache() does not take currently unregistering sysctl tables into account, which might result into a page fault in sysctl_follow_link() - add a check to fix it. This bug has been present since v3.4. Link: http://lkml.kernel.org/r/20180228013506.4915-1-danilokrummrich@dk-develop.de Fixes:0e47c99d7f
("sysctl: Replace root_list with links between sysctl_table_sets") Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de> Acked-by: Kees Cook <keescook@chromium.org> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Cc: "Luis R . Rodriguez" <mcgrof@kernel.org> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
2bbb81de2b
commit
b621438301
1 changed files with 3 additions and 0 deletions
|
@ -660,7 +660,10 @@ static bool proc_sys_link_fill_cache(struct file *file,
|
|||
struct ctl_table *table)
|
||||
{
|
||||
bool ret = true;
|
||||
|
||||
head = sysctl_head_grab(head);
|
||||
if (IS_ERR(head))
|
||||
return false;
|
||||
|
||||
if (S_ISLNK(table->mode)) {
|
||||
/* It is not an error if we can not follow the link ignore it */
|
||||
|
|
Loading…
Reference in a new issue