mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-03 07:38:10 +00:00
Code Issues Releases Wiki Activity

gpio: mockup: improve readability

Browse source 
We currently shift bits here and there without actually explaining
what we're doing. Add some helper variables with names indicating
their purpose to improve the code readability.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Bartosz Golaszewski 2017-06-09 13:41:28 +02:00 committed by Linus Walleij
parent b6c2e77d34
commit b652336d3f
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
drivers/gpio/gpio-mockup.c
View file

@ -27,6 +27,11 @@
#define GPIO_MOCKUP_NAME "gpio-mockup" #define GPIO_MOCKUP_NAME "gpio-mockup"
#define GPIO_MOCKUP_MAX_GC 10 #define GPIO_MOCKUP_MAX_GC 10
/*
* We're storing two values per chip: the GPIO base and the number
* of GPIO lines.
*/
#define GPIO_MOCKUP_MAX_RANGES (GPIO_MOCKUP_MAX_GC * 2)
enum { enum {
GPIO_MOCKUP_DIR_OUT = 0, GPIO_MOCKUP_DIR_OUT = 0,
@ -62,7 +67,7 @@ struct gpio_mockup_dbgfs_private {
int offset; int offset;
}; };
static int gpio_mockup_ranges[GPIO_MOCKUP_MAX_GC << 1]; static int gpio_mockup_ranges[GPIO_MOCKUP_MAX_RANGES];
static int gpio_mockup_params_nr; static int gpio_mockup_params_nr;
module_param_array(gpio_mockup_ranges, int, &gpio_mockup_params_nr, 0400); module_param_array(gpio_mockup_ranges, int, &gpio_mockup_params_nr, 0400);
@ -329,23 +334,24 @@ static int gpio_mockup_add(struct device *dev,
static int gpio_mockup_probe(struct platform_device *pdev) static int gpio_mockup_probe(struct platform_device *pdev)
{ {
struct gpio_mockup_chip *chips; int ret, i, base, ngpio, num_chips;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
int ret, i, base, ngpio; struct gpio_mockup_chip *chips;
char *chip_name; char *chip_name;
if (gpio_mockup_params_nr < 2 || (gpio_mockup_params_nr % 2)) if (gpio_mockup_params_nr < 2 || (gpio_mockup_params_nr % 2))
return -EINVAL; return -EINVAL;
chips = devm_kzalloc(dev, /* Each chip is described by two values. */
sizeof(*chips) * (gpio_mockup_params_nr >> 1), num_chips = gpio_mockup_params_nr / 2;
GFP_KERNEL);
chips = devm_kzalloc(dev, sizeof(*chips) * num_chips, GFP_KERNEL);
if (!chips) if (!chips)
return -ENOMEM; return -ENOMEM;
platform_set_drvdata(pdev, chips); platform_set_drvdata(pdev, chips);
for (i = 0; i < gpio_mockup_params_nr >> 1; i++) { for (i = 0; i < num_chips; i++) {
base = gpio_mockup_ranges[i * 2]; base = gpio_mockup_ranges[i * 2];
if (base == -1) if (base == -1)