mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-22 00:40:03 +00:00
stmmac: fix DMA channel hang in half-duplex mode
HW does not support Half-duplex mode in multi-queue scenario. Fix it by not advertising the Half-Duplex mode if multi-queue enabled. Signed-off-by: Bhadram Varka <vbhadram@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
bc8a2d9bcb
commit
b6cfffa7ad
1 changed files with 10 additions and 0 deletions
|
@ -928,6 +928,7 @@ static void stmmac_check_pcs_mode(struct stmmac_priv *priv)
|
|||
static int stmmac_init_phy(struct net_device *dev)
|
||||
{
|
||||
struct stmmac_priv *priv = netdev_priv(dev);
|
||||
u32 tx_cnt = priv->plat->tx_queues_to_use;
|
||||
struct phy_device *phydev;
|
||||
char phy_id_fmt[MII_BUS_ID_SIZE + 3];
|
||||
char bus_id[MII_BUS_ID_SIZE];
|
||||
|
@ -968,6 +969,15 @@ static int stmmac_init_phy(struct net_device *dev)
|
|||
phydev->advertising &= ~(SUPPORTED_1000baseT_Half |
|
||||
SUPPORTED_1000baseT_Full);
|
||||
|
||||
/*
|
||||
* Half-duplex mode not supported with multiqueue
|
||||
* half-duplex can only works with single queue
|
||||
*/
|
||||
if (tx_cnt > 1)
|
||||
phydev->supported &= ~(SUPPORTED_1000baseT_Half |
|
||||
SUPPORTED_100baseT_Half |
|
||||
SUPPORTED_10baseT_Half);
|
||||
|
||||
/*
|
||||
* Broken HW is sometimes missing the pull-up resistor on the
|
||||
* MDIO line, which results in reads to non-existent devices returning
|
||||
|
|
Loading…
Reference in a new issue