mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-24 09:50:04 +00:00
Code Issues Releases Wiki Activity

usb: gadget: udc: max3420_udc: remove using list iterator after loop body as a ptr

Browse source 
If the list does not contain the expected element, the value of
list_for_each_entry() iterator will not point to a valid structure.
To avoid type confusion in such case, the list iterator
scope will be limited to list_for_each_entry() loop.

In preparation to limiting scope of a list iterator to the list traversal
loop, use a dedicated pointer to point to the found element [1].
Determining if an element was found is then simply checking if
the pointer is != NULL instead of using the potentially bogus pointer.

Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220308171818.384491-20-jakobkoschel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jakob Koschel 2022-03-08 18:18:11 +01:00 committed by Greg Kroah-Hartman
parent eb6db9ccf6
commit b832eb1d57
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
drivers/usb/gadget/udc/max3420_udc.c
View file

@ -1044,22 +1044,26 @@ static int max3420_ep_queue(struct usb_ep *_ep, struct usb_request *_req,
static int max3420_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
{
struct max3420_req *t, *req = to_max3420_req(_req);
struct max3420_req *t = NULL;
struct max3420_req *req = to_max3420_req(_req);
struct max3420_req *iter;
struct max3420_ep *ep = to_max3420_ep(_ep);
unsigned long flags;
spin_lock_irqsave(&ep->lock, flags);
/* Pluck the descriptor from queue */
list_for_each_entry(t, &ep->queue, queue)
if (t == req) {
list_del_init(&req->queue);
break;
}
list_for_each_entry(iter, &ep->queue, queue) {
if (iter != req)
continue;
list_del_init(&req->queue);
t = iter;
break;
}
spin_unlock_irqrestore(&ep->lock, flags);
if (t == req)
if (t)
max3420_req_done(req, -ECONNRESET);
return 0;