mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
ASoC: wm_adsp: fix memleak in wm_adsp_buffer_populate
[ Upstream commit29046a78a3
] When wm_adsp_buffer_read() fails, we should free buf->regions. Otherwise, the callers of wm_adsp_buffer_populate() will directly free buf on failure, which makes buf->regions a leaked memory. Fixes:a792af69b0
("ASoC: wm_adsp: Refactor compress stream initialisation") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://lore.kernel.org/r/20231204074158.12026-1-dinghao.liu@zju.edu.cn Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
0ca497a90e
commit
b8668fe7a5
1 changed files with 6 additions and 2 deletions
|
@ -1451,12 +1451,12 @@ static int wm_adsp_buffer_populate(struct wm_adsp_compr_buf *buf)
|
|||
ret = wm_adsp_buffer_read(buf, caps->region_defs[i].base_offset,
|
||||
®ion->base_addr);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
goto err;
|
||||
|
||||
ret = wm_adsp_buffer_read(buf, caps->region_defs[i].size_offset,
|
||||
&offset);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
goto err;
|
||||
|
||||
region->cumulative_size = offset;
|
||||
|
||||
|
@ -1467,6 +1467,10 @@ static int wm_adsp_buffer_populate(struct wm_adsp_compr_buf *buf)
|
|||
}
|
||||
|
||||
return 0;
|
||||
|
||||
err:
|
||||
kfree(buf->regions);
|
||||
return ret;
|
||||
}
|
||||
|
||||
static void wm_adsp_buffer_clear(struct wm_adsp_compr_buf *buf)
|
||||
|
|
Loading…
Reference in a new issue