mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
USB: ehci-hcd: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
2ee127242a
commit
b8fc774340
2 changed files with 8 additions and 27 deletions
|
@ -1028,29 +1028,15 @@ static inline void create_debug_files(struct ehci_hcd *ehci)
|
|||
struct usb_bus *bus = &ehci_to_hcd(ehci)->self;
|
||||
|
||||
ehci->debug_dir = debugfs_create_dir(bus->bus_name, ehci_debug_root);
|
||||
if (!ehci->debug_dir)
|
||||
return;
|
||||
|
||||
if (!debugfs_create_file("async", S_IRUGO, ehci->debug_dir, bus,
|
||||
&debug_async_fops))
|
||||
goto file_error;
|
||||
|
||||
if (!debugfs_create_file("bandwidth", S_IRUGO, ehci->debug_dir, bus,
|
||||
&debug_bandwidth_fops))
|
||||
goto file_error;
|
||||
|
||||
if (!debugfs_create_file("periodic", S_IRUGO, ehci->debug_dir, bus,
|
||||
&debug_periodic_fops))
|
||||
goto file_error;
|
||||
|
||||
if (!debugfs_create_file("registers", S_IRUGO, ehci->debug_dir, bus,
|
||||
&debug_registers_fops))
|
||||
goto file_error;
|
||||
|
||||
return;
|
||||
|
||||
file_error:
|
||||
debugfs_remove_recursive(ehci->debug_dir);
|
||||
debugfs_create_file("async", S_IRUGO, ehci->debug_dir, bus,
|
||||
&debug_async_fops);
|
||||
debugfs_create_file("bandwidth", S_IRUGO, ehci->debug_dir, bus,
|
||||
&debug_bandwidth_fops);
|
||||
debugfs_create_file("periodic", S_IRUGO, ehci->debug_dir, bus,
|
||||
&debug_periodic_fops);
|
||||
debugfs_create_file("registers", S_IRUGO, ehci->debug_dir, bus,
|
||||
&debug_registers_fops);
|
||||
}
|
||||
|
||||
static inline void remove_debug_files(struct ehci_hcd *ehci)
|
||||
|
|
|
@ -1311,10 +1311,6 @@ static int __init ehci_hcd_init(void)
|
|||
|
||||
#ifdef CONFIG_DYNAMIC_DEBUG
|
||||
ehci_debug_root = debugfs_create_dir("ehci", usb_debug_root);
|
||||
if (!ehci_debug_root) {
|
||||
retval = -ENOENT;
|
||||
goto err_debug;
|
||||
}
|
||||
#endif
|
||||
|
||||
#ifdef PLATFORM_DRIVER
|
||||
|
@ -1361,7 +1357,6 @@ static int __init ehci_hcd_init(void)
|
|||
#ifdef CONFIG_DYNAMIC_DEBUG
|
||||
debugfs_remove(ehci_debug_root);
|
||||
ehci_debug_root = NULL;
|
||||
err_debug:
|
||||
#endif
|
||||
clear_bit(USB_EHCI_LOADED, &usb_hcds_loaded);
|
||||
return retval;
|
||||
|
|
Loading…
Reference in a new issue