mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 10:29:37 +00:00
libnvdimm, region : make 'resource' attribute only readable by root
For the same reason that /proc/iomem returns 0's for non-root readers
and acpi tables are root-only, make the 'resource' attribute for region
devices only readable by root. Otherwise we disclose physical address
information.
Fixes: 802f4be6fe
("libnvdimm: Add 'resource' sysfs attribute to regions")
Cc: <stable@vger.kernel.org>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
parent
d083e6dae0
commit
b8ff981f88
1 changed files with 6 additions and 2 deletions
|
@ -562,8 +562,12 @@ static umode_t region_visible(struct kobject *kobj, struct attribute *a, int n)
|
||||||
if (!is_nd_pmem(dev) && a == &dev_attr_badblocks.attr)
|
if (!is_nd_pmem(dev) && a == &dev_attr_badblocks.attr)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
if (!is_nd_pmem(dev) && a == &dev_attr_resource.attr)
|
if (a == &dev_attr_resource.attr) {
|
||||||
|
if (is_nd_pmem(dev))
|
||||||
|
return 0400;
|
||||||
|
else
|
||||||
return 0;
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
if (a == &dev_attr_deep_flush.attr) {
|
if (a == &dev_attr_deep_flush.attr) {
|
||||||
int has_flush = nvdimm_has_flush(nd_region);
|
int has_flush = nvdimm_has_flush(nd_region);
|
||||||
|
|
Loading…
Reference in a new issue