mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
fbdev/amba-clcd: Initialize fb_ops to fbdev I/O-memory helpers
Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the callbacks being NULL for a default implementation to be invoked; hence requiring the I/O helpers to be built in any case. Setting all callbacks in all drivers explicitly will allow to make the I/O helpers optional. This benefits systems that do not use these functions. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-4-tzimmermann@suse.de
This commit is contained in:
parent
5a5015aaaa
commit
b910005c98
2 changed files with 3 additions and 6 deletions
|
@ -118,9 +118,7 @@ config FB_ARMCLCD
|
||||||
tristate "ARM PrimeCell PL110 support"
|
tristate "ARM PrimeCell PL110 support"
|
||||||
depends on ARM || ARM64 || COMPILE_TEST
|
depends on ARM || ARM64 || COMPILE_TEST
|
||||||
depends on FB && ARM_AMBA && HAS_IOMEM
|
depends on FB && ARM_AMBA && HAS_IOMEM
|
||||||
select FB_CFB_FILLRECT
|
select FB_IOMEM_HELPERS
|
||||||
select FB_CFB_COPYAREA
|
|
||||||
select FB_CFB_IMAGEBLIT
|
|
||||||
select FB_MODE_HELPERS if OF
|
select FB_MODE_HELPERS if OF
|
||||||
select VIDEOMODE_HELPERS if OF
|
select VIDEOMODE_HELPERS if OF
|
||||||
select BACKLIGHT_CLASS_DEVICE if OF
|
select BACKLIGHT_CLASS_DEVICE if OF
|
||||||
|
|
|
@ -412,13 +412,12 @@ static int clcdfb_mmap(struct fb_info *info,
|
||||||
|
|
||||||
static const struct fb_ops clcdfb_ops = {
|
static const struct fb_ops clcdfb_ops = {
|
||||||
.owner = THIS_MODULE,
|
.owner = THIS_MODULE,
|
||||||
|
__FB_DEFAULT_IOMEM_OPS_RDWR,
|
||||||
.fb_check_var = clcdfb_check_var,
|
.fb_check_var = clcdfb_check_var,
|
||||||
.fb_set_par = clcdfb_set_par,
|
.fb_set_par = clcdfb_set_par,
|
||||||
.fb_setcolreg = clcdfb_setcolreg,
|
.fb_setcolreg = clcdfb_setcolreg,
|
||||||
.fb_blank = clcdfb_blank,
|
.fb_blank = clcdfb_blank,
|
||||||
.fb_fillrect = cfb_fillrect,
|
__FB_DEFAULT_IOMEM_OPS_DRAW,
|
||||||
.fb_copyarea = cfb_copyarea,
|
|
||||||
.fb_imageblit = cfb_imageblit,
|
|
||||||
.fb_mmap = clcdfb_mmap,
|
.fb_mmap = clcdfb_mmap,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue