mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
i915: don't call drm_atomic_state_put on invalid pointer
The introduction of reference counting on the state structures caused
sanitize_watermarks() in i915 to break in the error handling case,
as pointed out by gcc -Wmaybe-uninitialized
drivers/gpu/drm/i915/intel_display.c: In function ‘intel_modeset_init’:
include/drm/drm_atomic.h:224:2: error: ‘state’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
This changes the function back to only drop the reference count
when it was successfully allocated first.
Fixes: 0853695c3b
("drm: Add reference counting to drm_atomic_state")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20161018151652.2690201-1-arnd@arndb.de
This commit is contained in:
parent
488546fc4d
commit
b9a1b7179c
1 changed files with 3 additions and 2 deletions
|
@ -16294,7 +16294,7 @@ static void sanitize_watermarks(struct drm_device *dev)
|
|||
* BIOS-programmed watermarks untouched and hope for the best.
|
||||
*/
|
||||
WARN(true, "Could not determine valid watermarks for inherited state\n");
|
||||
goto fail;
|
||||
goto put_state;
|
||||
}
|
||||
|
||||
/* Write calculated watermark values back */
|
||||
|
@ -16305,8 +16305,9 @@ static void sanitize_watermarks(struct drm_device *dev)
|
|||
dev_priv->display.optimize_watermarks(cs);
|
||||
}
|
||||
|
||||
fail:
|
||||
put_state:
|
||||
drm_atomic_state_put(state);
|
||||
fail:
|
||||
drm_modeset_drop_locks(&ctx);
|
||||
drm_modeset_acquire_fini(&ctx);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue