mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 05:48:40 +00:00
fs/proc/base.c: save decrement during lookup/readdir in /proc/$PID
Comparison for "<" works equally well as comparison for "<=" but one SUB/LEA is saved (no, it is not optimised away, at least here). Link: http://lkml.kernel.org/r/20161122195143.GA29812@avx2 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
209b14dc03
commit
bac5f5d56b
1 changed files with 4 additions and 4 deletions
|
@ -2412,14 +2412,14 @@ static struct dentry *proc_pident_lookup(struct inode *dir,
|
||||||
* Yes, it does not scale. And it should not. Don't add
|
* Yes, it does not scale. And it should not. Don't add
|
||||||
* new entries into /proc/<tgid>/ without very good reasons.
|
* new entries into /proc/<tgid>/ without very good reasons.
|
||||||
*/
|
*/
|
||||||
last = &ents[nents - 1];
|
last = &ents[nents];
|
||||||
for (p = ents; p <= last; p++) {
|
for (p = ents; p < last; p++) {
|
||||||
if (p->len != dentry->d_name.len)
|
if (p->len != dentry->d_name.len)
|
||||||
continue;
|
continue;
|
||||||
if (!memcmp(dentry->d_name.name, p->name, p->len))
|
if (!memcmp(dentry->d_name.name, p->name, p->len))
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
if (p > last)
|
if (p >= last)
|
||||||
goto out;
|
goto out;
|
||||||
|
|
||||||
error = proc_pident_instantiate(dir, dentry, task, p);
|
error = proc_pident_instantiate(dir, dentry, task, p);
|
||||||
|
@ -2444,7 +2444,7 @@ static int proc_pident_readdir(struct file *file, struct dir_context *ctx,
|
||||||
if (ctx->pos >= nents + 2)
|
if (ctx->pos >= nents + 2)
|
||||||
goto out;
|
goto out;
|
||||||
|
|
||||||
for (p = ents + (ctx->pos - 2); p <= ents + nents - 1; p++) {
|
for (p = ents + (ctx->pos - 2); p < ents + nents; p++) {
|
||||||
if (!proc_fill_cache(file, ctx, p->name, p->len,
|
if (!proc_fill_cache(file, ctx, p->name, p->len,
|
||||||
proc_pident_instantiate, task, p))
|
proc_pident_instantiate, task, p))
|
||||||
break;
|
break;
|
||||||
|
|
Loading…
Reference in a new issue