mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
net/enetc: Fix wrong return value in enetc_psfp_parse_clsflower()
In the case of invalid rule, a positive value EINVAL is returned here. I think this is a typo error. It is necessary to return an error value. Cc: Po Liu <Po.Liu@nxp.com> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
0470a48880
commit
bace287c55
1 changed files with 4 additions and 4 deletions
|
@ -1130,7 +1130,7 @@ static int enetc_psfp_parse_clsflower(struct enetc_ndev_priv *priv,
|
|||
!is_zero_ether_addr(match.mask->src)) {
|
||||
NL_SET_ERR_MSG_MOD(extack,
|
||||
"Cannot match on both source and destination MAC");
|
||||
err = EINVAL;
|
||||
err = -EINVAL;
|
||||
goto free_filter;
|
||||
}
|
||||
|
||||
|
@ -1138,7 +1138,7 @@ static int enetc_psfp_parse_clsflower(struct enetc_ndev_priv *priv,
|
|||
if (!is_broadcast_ether_addr(match.mask->dst)) {
|
||||
NL_SET_ERR_MSG_MOD(extack,
|
||||
"Masked matching on destination MAC not supported");
|
||||
err = EINVAL;
|
||||
err = -EINVAL;
|
||||
goto free_filter;
|
||||
}
|
||||
ether_addr_copy(filter->sid.dst_mac, match.key->dst);
|
||||
|
@ -1149,7 +1149,7 @@ static int enetc_psfp_parse_clsflower(struct enetc_ndev_priv *priv,
|
|||
if (!is_broadcast_ether_addr(match.mask->src)) {
|
||||
NL_SET_ERR_MSG_MOD(extack,
|
||||
"Masked matching on source MAC not supported");
|
||||
err = EINVAL;
|
||||
err = -EINVAL;
|
||||
goto free_filter;
|
||||
}
|
||||
ether_addr_copy(filter->sid.src_mac, match.key->src);
|
||||
|
@ -1157,7 +1157,7 @@ static int enetc_psfp_parse_clsflower(struct enetc_ndev_priv *priv,
|
|||
}
|
||||
} else {
|
||||
NL_SET_ERR_MSG_MOD(extack, "Unsupported, must include ETH_ADDRS");
|
||||
err = EINVAL;
|
||||
err = -EINVAL;
|
||||
goto free_filter;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue