mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-27 12:57:53 +00:00
Code Issues Releases Wiki Activity

xen: branch for v6.2-rc4

Browse source 
-----BEGIN PGP SIGNATURE-----
 
 iHUEABYIAB0WIQRTLbB6QfY48x44uB6AXGG7T9hjvgUCY76ohgAKCRCAXGG7T9hj
 vo8fAP0XJ94B7asqcN4W3EyeyfqxUf1eZvmWRhrbKqpLnmHLaQEA/uJBkXL49Zj7
 TTcbxR1coJ/hPwhtmONU4TNtCZ+RXw0=
 =2Ib5
 -----END PGP SIGNATURE-----

Merge tag 'for-linus-6.2-rc4-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip

Pull xen fixes from Juergen Gross:

 - two cleanup patches

 - a fix of a memory leak in the Xen pvfront driver

 - a fix of a locking issue in the Xen hypervisor console driver

* tag 'for-linus-6.2-rc4-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip:
  xen/pvcalls: free active map buffer on pvcalls_front_free_map
  hvc/xen: lock console list traversal
  x86/xen: Remove the unused function p2m_index()
  xen: make remove callback of xen driver void returned
This commit is contained in:
Linus Torvalds 2023-01-12 17:02:20 -06:00
commit bad8c4a850
20 changed files with 54 additions and 70 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
arch/x86/xen/p2m.c
View file

@ -134,11 +134,6 @@ static inline unsigned p2m_mid_index(unsigned long pfn)
return (pfn / P2M_PER_PAGE) % P2M_MID_PER_PAGE; return (pfn / P2M_PER_PAGE) % P2M_MID_PER_PAGE;
} }
static inline unsigned p2m_index(unsigned long pfn)
{
return pfn % P2M_PER_PAGE;
}
static void p2m_top_mfn_init(unsigned long *top) static void p2m_top_mfn_init(unsigned long *top)
{ {
unsigned i; unsigned i;

4
drivers/block/xen-blkback/xenbus.c
View file

@ -524,7 +524,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
return 0; return 0;
} }
static int xen_blkbk_remove(struct xenbus_device *dev) static void xen_blkbk_remove(struct xenbus_device *dev)
{ {
struct backend_info *be = dev_get_drvdata(&dev->dev); struct backend_info *be = dev_get_drvdata(&dev->dev);
@ -547,8 +547,6 @@ static int xen_blkbk_remove(struct xenbus_device *dev)
/* Put the reference we set in xen_blkif_alloc(). */ /* Put the reference we set in xen_blkif_alloc(). */
xen_blkif_put(be->blkif); xen_blkif_put(be->blkif);
} }
return 0;
} }
int xen_blkbk_flush_diskcache(struct xenbus_transaction xbt, int xen_blkbk_flush_diskcache(struct xenbus_transaction xbt,

3
drivers/block/xen-blkfront.c
View file

@ -2467,7 +2467,7 @@ static void blkback_changed(struct xenbus_device *dev,
} }
} }
static int blkfront_remove(struct xenbus_device *xbdev) static void blkfront_remove(struct xenbus_device *xbdev)
{ {
struct blkfront_info *info = dev_get_drvdata(&xbdev->dev); struct blkfront_info *info = dev_get_drvdata(&xbdev->dev);
@ -2488,7 +2488,6 @@ static int blkfront_remove(struct xenbus_device *xbdev)
} }
kfree(info); kfree(info);
return 0;
} }
static int blkfront_is_ready(struct xenbus_device *dev) static int blkfront_is_ready(struct xenbus_device *dev)

3
drivers/char/tpm/xen-tpmfront.c
View file

@ -360,14 +360,13 @@ static int tpmfront_probe(struct xenbus_device *dev,
return tpm_chip_register(priv->chip); return tpm_chip_register(priv->chip);
} }
static int tpmfront_remove(struct xenbus_device *dev) static void tpmfront_remove(struct xenbus_device *dev)
{ {
struct tpm_chip *chip = dev_get_drvdata(&dev->dev); struct tpm_chip *chip = dev_get_drvdata(&dev->dev);
struct tpm_private *priv = dev_get_drvdata(&chip->dev); struct tpm_private *priv = dev_get_drvdata(&chip->dev);
tpm_chip_unregister(chip); tpm_chip_unregister(chip);
ring_free(priv); ring_free(priv);
dev_set_drvdata(&chip->dev, NULL); dev_set_drvdata(&chip->dev, NULL);
return 0;
} }
static int tpmfront_resume(struct xenbus_device *dev) static int tpmfront_resume(struct xenbus_device *dev)

3
drivers/gpu/drm/xen/xen_drm_front.c
View file

@ -717,7 +717,7 @@ static int xen_drv_probe(struct xenbus_device *xb_dev,
return xenbus_switch_state(xb_dev, XenbusStateInitialising); return xenbus_switch_state(xb_dev, XenbusStateInitialising);
} }
static int xen_drv_remove(struct xenbus_device *dev) static void xen_drv_remove(struct xenbus_device *dev)
{ {
struct xen_drm_front_info *front_info = dev_get_drvdata(&dev->dev); struct xen_drm_front_info *front_info = dev_get_drvdata(&dev->dev);
int to = 100; int to = 100;
@ -751,7 +751,6 @@ static int xen_drv_remove(struct xenbus_device *dev)
xen_drm_drv_fini(front_info); xen_drm_drv_fini(front_info);
xenbus_frontend_closed(dev); xenbus_frontend_closed(dev);
return 0;
} }
static const struct xenbus_device_id xen_driver_ids[] = { static const struct xenbus_device_id xen_driver_ids[] = {

5
drivers/input/misc/xen-kbdfront.c
View file

@ -51,7 +51,7 @@ module_param_array(ptr_size, int, NULL, 0444);
MODULE_PARM_DESC(ptr_size, MODULE_PARM_DESC(ptr_size,
"Pointing device width, height in pixels (default 800,600)"); "Pointing device width, height in pixels (default 800,600)");
static int xenkbd_remove(struct xenbus_device *); static void xenkbd_remove(struct xenbus_device *);
static int xenkbd_connect_backend(struct xenbus_device *, struct xenkbd_info *); static int xenkbd_connect_backend(struct xenbus_device *, struct xenkbd_info *);
static void xenkbd_disconnect_backend(struct xenkbd_info *); static void xenkbd_disconnect_backend(struct xenkbd_info *);
@ -404,7 +404,7 @@ static int xenkbd_resume(struct xenbus_device *dev)
return xenkbd_connect_backend(dev, info); return xenkbd_connect_backend(dev, info);
} }
static int xenkbd_remove(struct xenbus_device *dev) static void xenkbd_remove(struct xenbus_device *dev)
{ {
struct xenkbd_info *info = dev_get_drvdata(&dev->dev); struct xenkbd_info *info = dev_get_drvdata(&dev->dev);
@ -417,7 +417,6 @@ static int xenkbd_remove(struct xenbus_device *dev)
input_unregister_device(info->mtouch); input_unregister_device(info->mtouch);
free_page((unsigned long)info->page); free_page((unsigned long)info->page);
kfree(info); kfree(info);
return 0;
} }
static int xenkbd_connect_backend(struct xenbus_device *dev, static int xenkbd_connect_backend(struct xenbus_device *dev,

3
drivers/net/xen-netback/xenbus.c
View file

@ -977,7 +977,7 @@ static int read_xenbus_vif_flags(struct backend_info *be)
return 0; return 0;
} }
static int netback_remove(struct xenbus_device *dev) static void netback_remove(struct xenbus_device *dev)
{ {
struct backend_info *be = dev_get_drvdata(&dev->dev); struct backend_info *be = dev_get_drvdata(&dev->dev);
@ -992,7 +992,6 @@ static int netback_remove(struct xenbus_device *dev)
kfree(be->hotplug_script); kfree(be->hotplug_script);
kfree(be); kfree(be);
dev_set_drvdata(&dev->dev, NULL); dev_set_drvdata(&dev->dev, NULL);
return 0;
} }
/* /*

4
drivers/net/xen-netfront.c
View file

@ -2646,7 +2646,7 @@ static void xennet_bus_close(struct xenbus_device *dev)
} while (!ret); } while (!ret);
} }
static int xennet_remove(struct xenbus_device *dev) static void xennet_remove(struct xenbus_device *dev)
{ {
struct netfront_info *info = dev_get_drvdata(&dev->dev); struct netfront_info *info = dev_get_drvdata(&dev->dev);
@ -2662,8 +2662,6 @@ static int xennet_remove(struct xenbus_device *dev)
rtnl_unlock(); rtnl_unlock();
} }
xennet_free_netdev(info->netdev); xennet_free_netdev(info->netdev);
return 0;
} }
static const struct xenbus_device_id netfront_ids[] = { static const struct xenbus_device_id netfront_ids[] = {

4
drivers/pci/xen-pcifront.c
View file

@ -1055,14 +1055,12 @@ static int pcifront_xenbus_probe(struct xenbus_device *xdev,
return err; return err;
} }
static int pcifront_xenbus_remove(struct xenbus_device *xdev) static void pcifront_xenbus_remove(struct xenbus_device *xdev)
{ {
struct pcifront_device *pdev = dev_get_drvdata(&xdev->dev); struct pcifront_device *pdev = dev_get_drvdata(&xdev->dev);
if (pdev) if (pdev)
free_pdev(pdev); free_pdev(pdev);
return 0;
} }
static const struct xenbus_device_id xenpci_ids[] = { static const struct xenbus_device_id xenpci_ids[] = {

4
drivers/scsi/xen-scsifront.c
View file

@ -995,7 +995,7 @@ static int scsifront_suspend(struct xenbus_device *dev)
return err; return err;
} }
static int scsifront_remove(struct xenbus_device *dev) static void scsifront_remove(struct xenbus_device *dev)
{ {
struct vscsifrnt_info *info = dev_get_drvdata(&dev->dev); struct vscsifrnt_info *info = dev_get_drvdata(&dev->dev);
@ -1011,8 +1011,6 @@ static int scsifront_remove(struct xenbus_device *dev)
scsifront_free_ring(info); scsifront_free_ring(info);
scsi_host_put(info->host); scsi_host_put(info->host);
return 0;
} }
static void scsifront_disconnect(struct vscsifrnt_info *info) static void scsifront_disconnect(struct vscsifrnt_info *info)

50
drivers/tty/hvc/hvc_xen.c
View file

@ -52,17 +52,22 @@ static DEFINE_SPINLOCK(xencons_lock);
static struct xencons_info *vtermno_to_xencons(int vtermno) static struct xencons_info *vtermno_to_xencons(int vtermno)
{ {
struct xencons_info *entry, *n, *ret = NULL; struct xencons_info *entry, *ret = NULL;
unsigned long flags;
if (list_empty(&xenconsoles)) spin_lock_irqsave(&xencons_lock, flags);
return NULL; if (list_empty(&xenconsoles)) {
spin_unlock_irqrestore(&xencons_lock, flags);
return NULL;
}
list_for_each_entry_safe(entry, n, &xenconsoles, list) { list_for_each_entry(entry, &xenconsoles, list) {
if (entry->vtermno == vtermno) { if (entry->vtermno == vtermno) {
ret = entry; ret = entry;
break; break;
} }
} }
spin_unlock_irqrestore(&xencons_lock, flags);
return ret; return ret;
} }
@ -223,7 +228,7 @@ static int xen_hvm_console_init(void)
{ {
int r; int r;
uint64_t v = 0; uint64_t v = 0;
unsigned long gfn; unsigned long gfn, flags;
struct xencons_info *info; struct xencons_info *info;
if (!xen_hvm_domain()) if (!xen_hvm_domain())
@ -258,9 +263,9 @@ static int xen_hvm_console_init(void)
goto err; goto err;
info->vtermno = HVC_COOKIE; info->vtermno = HVC_COOKIE;
spin_lock(&xencons_lock); spin_lock_irqsave(&xencons_lock, flags);
list_add_tail(&info->list, &xenconsoles); list_add_tail(&info->list, &xenconsoles);
spin_unlock(&xencons_lock); spin_unlock_irqrestore(&xencons_lock, flags);
return 0; return 0;
err: err:
@ -283,6 +288,7 @@ static int xencons_info_pv_init(struct xencons_info *info, int vtermno)
static int xen_pv_console_init(void) static int xen_pv_console_init(void)
{ {
struct xencons_info *info; struct xencons_info *info;
unsigned long flags;
if (!xen_pv_domain()) if (!xen_pv_domain())
return -ENODEV; return -ENODEV;
@ -299,9 +305,9 @@ static int xen_pv_console_init(void)
/* already configured */ /* already configured */
return 0; return 0;
} }
spin_lock(&xencons_lock); spin_lock_irqsave(&xencons_lock, flags);
xencons_info_pv_init(info, HVC_COOKIE); xencons_info_pv_init(info, HVC_COOKIE);
spin_unlock(&xencons_lock); spin_unlock_irqrestore(&xencons_lock, flags);
return 0; return 0;
} }
@ -309,6 +315,7 @@ static int xen_pv_console_init(void)
static int xen_initial_domain_console_init(void) static int xen_initial_domain_console_init(void)
{ {
struct xencons_info *info; struct xencons_info *info;
unsigned long flags;
if (!xen_initial_domain()) if (!xen_initial_domain())
return -ENODEV; return -ENODEV;
@ -323,9 +330,9 @@ static int xen_initial_domain_console_init(void)
info->irq = bind_virq_to_irq(VIRQ_CONSOLE, 0, false); info->irq = bind_virq_to_irq(VIRQ_CONSOLE, 0, false);
info->vtermno = HVC_COOKIE; info->vtermno = HVC_COOKIE;
spin_lock(&xencons_lock); spin_lock_irqsave(&xencons_lock, flags);
list_add_tail(&info->list, &xenconsoles); list_add_tail(&info->list, &xenconsoles);
spin_unlock(&xencons_lock); spin_unlock_irqrestore(&xencons_lock, flags);
return 0; return 0;
} }
@ -380,10 +387,12 @@ static void xencons_free(struct xencons_info *info)
static int xen_console_remove(struct xencons_info *info) static int xen_console_remove(struct xencons_info *info)
{ {
unsigned long flags;
xencons_disconnect_backend(info); xencons_disconnect_backend(info);
spin_lock(&xencons_lock); spin_lock_irqsave(&xencons_lock, flags);
list_del(&info->list); list_del(&info->list);
spin_unlock(&xencons_lock); spin_unlock_irqrestore(&xencons_lock, flags);
if (info->xbdev != NULL) if (info->xbdev != NULL)
xencons_free(info); xencons_free(info);
else { else {
@ -394,9 +403,9 @@ static int xen_console_remove(struct xencons_info *info)
return 0; return 0;
} }
static int xencons_remove(struct xenbus_device *dev) static void xencons_remove(struct xenbus_device *dev)
{ {
return xen_console_remove(dev_get_drvdata(&dev->dev)); xen_console_remove(dev_get_drvdata(&dev->dev));
} }
static int xencons_connect_backend(struct xenbus_device *dev, static int xencons_connect_backend(struct xenbus_device *dev,
@ -464,6 +473,7 @@ static int xencons_probe(struct xenbus_device *dev,
{ {
int ret, devid; int ret, devid;
struct xencons_info *info; struct xencons_info *info;
unsigned long flags;
devid = dev->nodename[strlen(dev->nodename) - 1] - '0'; devid = dev->nodename[strlen(dev->nodename) - 1] - '0';
if (devid == 0) if (devid == 0)
@ -482,9 +492,9 @@ static int xencons_probe(struct xenbus_device *dev,
ret = xencons_connect_backend(dev, info); ret = xencons_connect_backend(dev, info);
if (ret < 0) if (ret < 0)
goto error; goto error;
spin_lock(&xencons_lock); spin_lock_irqsave(&xencons_lock, flags);
list_add_tail(&info->list, &xenconsoles); list_add_tail(&info->list, &xenconsoles);
spin_unlock(&xencons_lock); spin_unlock_irqrestore(&xencons_lock, flags);
return 0; return 0;
@ -584,10 +594,12 @@ static int __init xen_hvc_init(void)
info->hvc = hvc_alloc(HVC_COOKIE, info->irq, ops, 256); info->hvc = hvc_alloc(HVC_COOKIE, info->irq, ops, 256);
if (IS_ERR(info->hvc)) { if (IS_ERR(info->hvc)) {
unsigned long flags;
r = PTR_ERR(info->hvc); r = PTR_ERR(info->hvc);
spin_lock(&xencons_lock); spin_lock_irqsave(&xencons_lock, flags);
list_del(&info->list); list_del(&info->list);
spin_unlock(&xencons_lock); spin_unlock_irqrestore(&xencons_lock, flags);
if (info->irq) if (info->irq)
unbind_from_irqhandler(info->irq, NULL); unbind_from_irqhandler(info->irq, NULL);
kfree(info); kfree(info);

4
drivers/usb/host/xen-hcd.c
View file

@ -1530,15 +1530,13 @@ static void xenhcd_backend_changed(struct xenbus_device *dev,
} }
} }
static int xenhcd_remove(struct xenbus_device *dev) static void xenhcd_remove(struct xenbus_device *dev)
{ {
struct xenhcd_info *info = dev_get_drvdata(&dev->dev); struct xenhcd_info *info = dev_get_drvdata(&dev->dev);
struct usb_hcd *hcd = xenhcd_info_to_hcd(info); struct usb_hcd *hcd = xenhcd_info_to_hcd(info);
xenhcd_destroy_rings(info); xenhcd_destroy_rings(info);
usb_put_hcd(hcd); usb_put_hcd(hcd);
return 0;
} }
static int xenhcd_probe(struct xenbus_device *dev, static int xenhcd_probe(struct xenbus_device *dev,

6
drivers/video/fbdev/xen-fbfront.c
View file

@ -67,7 +67,7 @@ MODULE_PARM_DESC(video,
"Video memory size in MB, width, height in pixels (default 2,800,600)"); "Video memory size in MB, width, height in pixels (default 2,800,600)");
static void xenfb_make_preferred_console(void); static void xenfb_make_preferred_console(void);
static int xenfb_remove(struct xenbus_device *); static void xenfb_remove(struct xenbus_device *);
static void xenfb_init_shared_page(struct xenfb_info *, struct fb_info *); static void xenfb_init_shared_page(struct xenfb_info *, struct fb_info *);
static int xenfb_connect_backend(struct xenbus_device *, struct xenfb_info *); static int xenfb_connect_backend(struct xenbus_device *, struct xenfb_info *);
static void xenfb_disconnect_backend(struct xenfb_info *); static void xenfb_disconnect_backend(struct xenfb_info *);
@ -523,7 +523,7 @@ static int xenfb_resume(struct xenbus_device *dev)
return xenfb_connect_backend(dev, info); return xenfb_connect_backend(dev, info);
} }
static int xenfb_remove(struct xenbus_device *dev) static void xenfb_remove(struct xenbus_device *dev)
{ {
struct xenfb_info *info = dev_get_drvdata(&dev->dev); struct xenfb_info *info = dev_get_drvdata(&dev->dev);
@ -538,8 +538,6 @@ static int xenfb_remove(struct xenbus_device *dev)
vfree(info->gfns); vfree(info->gfns);
vfree(info->fb); vfree(info->fb);
kfree(info); kfree(info);
return 0;
} }
static unsigned long vmalloc_to_gfn(void *address) static unsigned long vmalloc_to_gfn(void *address)

3
drivers/xen/pvcalls-back.c
View file

@ -1181,9 +1181,8 @@ static void pvcalls_back_changed(struct xenbus_device *dev,
} }
} }
static int pvcalls_back_remove(struct xenbus_device *dev) static void pvcalls_back_remove(struct xenbus_device *dev)
{ {
return 0;
} }
static int pvcalls_back_uevent(struct xenbus_device *xdev, static int pvcalls_back_uevent(struct xenbus_device *xdev,

7
drivers/xen/pvcalls-front.c
View file

@ -225,6 +225,8 @@ static irqreturn_t pvcalls_front_event_handler(int irq, void *dev_id)
return IRQ_HANDLED; return IRQ_HANDLED;
} }
static void free_active_ring(struct sock_mapping *map);
static void pvcalls_front_free_map(struct pvcalls_bedata *bedata, static void pvcalls_front_free_map(struct pvcalls_bedata *bedata,
struct sock_mapping *map) struct sock_mapping *map)
{ {
@ -240,7 +242,7 @@ static void pvcalls_front_free_map(struct pvcalls_bedata *bedata,
for (i = 0; i < (1 << PVCALLS_RING_ORDER); i++) for (i = 0; i < (1 << PVCALLS_RING_ORDER); i++)
gnttab_end_foreign_access(map->active.ring->ref[i], NULL); gnttab_end_foreign_access(map->active.ring->ref[i], NULL);
gnttab_end_foreign_access(map->active.ref, NULL); gnttab_end_foreign_access(map->active.ref, NULL);
free_page((unsigned long)map->active.ring); free_active_ring(map);
kfree(map); kfree(map);
} }
@ -1085,7 +1087,7 @@ static const struct xenbus_device_id pvcalls_front_ids[] = {
{ "" } { "" }
}; };
static int pvcalls_front_remove(struct xenbus_device *dev) static void pvcalls_front_remove(struct xenbus_device *dev)
{ {
struct pvcalls_bedata *bedata; struct pvcalls_bedata *bedata;
struct sock_mapping *map = NULL, *n; struct sock_mapping *map = NULL, *n;
@ -1121,7 +1123,6 @@ static int pvcalls_front_remove(struct xenbus_device *dev)
kfree(bedata->ring.sring); kfree(bedata->ring.sring);
kfree(bedata); kfree(bedata);
xenbus_switch_state(dev, XenbusStateClosed); xenbus_switch_state(dev, XenbusStateClosed);
return 0;
} }
static int pvcalls_front_probe(struct xenbus_device *dev, static int pvcalls_front_probe(struct xenbus_device *dev,

4
drivers/xen/xen-pciback/xenbus.c
View file

@ -716,14 +716,12 @@ static int xen_pcibk_xenbus_probe(struct xenbus_device *dev,
return err; return err;
} }
static int xen_pcibk_xenbus_remove(struct xenbus_device *dev) static void xen_pcibk_xenbus_remove(struct xenbus_device *dev)
{ {
struct xen_pcibk_device *pdev = dev_get_drvdata(&dev->dev); struct xen_pcibk_device *pdev = dev_get_drvdata(&dev->dev);
if (pdev != NULL) if (pdev != NULL)
free_pdev(pdev); free_pdev(pdev);
return 0;
} }
static const struct xenbus_device_id xen_pcibk_ids[] = { static const struct xenbus_device_id xen_pcibk_ids[] = {

4
drivers/xen/xen-scsiback.c
View file

@ -1249,7 +1249,7 @@ static void scsiback_release_translation_entry(struct vscsibk_info *info)
spin_unlock_irqrestore(&info->v2p_lock, flags); spin_unlock_irqrestore(&info->v2p_lock, flags);
} }
static int scsiback_remove(struct xenbus_device *dev) static void scsiback_remove(struct xenbus_device *dev)
{ {
struct vscsibk_info *info = dev_get_drvdata(&dev->dev); struct vscsibk_info *info = dev_get_drvdata(&dev->dev);
@ -1261,8 +1261,6 @@ static int scsiback_remove(struct xenbus_device *dev)
gnttab_page_cache_shrink(&info->free_pages, 0); gnttab_page_cache_shrink(&info->free_pages, 0);
dev_set_drvdata(&dev->dev, NULL); dev_set_drvdata(&dev->dev, NULL);
return 0;
} }
static int scsiback_probe(struct xenbus_device *dev, static int scsiback_probe(struct xenbus_device *dev,

2
include/xen/xenbus.h
View file

@ -117,7 +117,7 @@ struct xenbus_driver {
const struct xenbus_device_id *id); const struct xenbus_device_id *id);
void (*otherend_changed)(struct xenbus_device *dev, void (*otherend_changed)(struct xenbus_device *dev,
enum xenbus_state backend_state); enum xenbus_state backend_state);
int (*remove)(struct xenbus_device *dev); void (*remove)(struct xenbus_device *dev);
int (*suspend)(struct xenbus_device *dev); int (*suspend)(struct xenbus_device *dev);
int (*resume)(struct xenbus_device *dev); int (*resume)(struct xenbus_device *dev);
int (*uevent)(struct xenbus_device *, struct kobj_uevent_env *); int (*uevent)(struct xenbus_device *, struct kobj_uevent_env *);

3
net/9p/trans_xen.c
View file

@ -305,13 +305,12 @@ static void xen_9pfs_front_free(struct xen_9pfs_front_priv *priv)
kfree(priv); kfree(priv);
} }
static int xen_9pfs_front_remove(struct xenbus_device *dev) static void xen_9pfs_front_remove(struct xenbus_device *dev)
{ {
struct xen_9pfs_front_priv *priv = dev_get_drvdata(&dev->dev); struct xen_9pfs_front_priv *priv = dev_get_drvdata(&dev->dev);
dev_set_drvdata(&dev->dev, NULL); dev_set_drvdata(&dev->dev, NULL);
xen_9pfs_front_free(priv); xen_9pfs_front_free(priv);
return 0;
} }
static int xen_9pfs_front_alloc_dataring(struct xenbus_device *dev, static int xen_9pfs_front_alloc_dataring(struct xenbus_device *dev,

3
sound/xen/xen_snd_front.c
View file

@ -311,7 +311,7 @@ static int xen_drv_probe(struct xenbus_device *xb_dev,
return xenbus_switch_state(xb_dev, XenbusStateInitialising); return xenbus_switch_state(xb_dev, XenbusStateInitialising);
} }
static int xen_drv_remove(struct xenbus_device *dev) static void xen_drv_remove(struct xenbus_device *dev)
{ {
struct xen_snd_front_info *front_info = dev_get_drvdata(&dev->dev); struct xen_snd_front_info *front_info = dev_get_drvdata(&dev->dev);
int to = 100; int to = 100;
@ -345,7 +345,6 @@ static int xen_drv_remove(struct xenbus_device *dev)
xen_snd_drv_fini(front_info); xen_snd_drv_fini(front_info);
xenbus_frontend_closed(dev); xenbus_frontend_closed(dev);
return 0;
} }
static const struct xenbus_device_id xen_drv_ids[] = { static const struct xenbus_device_id xen_drv_ids[] = {