mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-06 16:49:22 +00:00
Code Issues Releases Wiki Activity

drm/omap: Remove duplicate calls to .set_timings() operation

Browse source 
The omap_dss_device .set_timings() operations are called directly from
omap_encoder_update(), and indirectly from the omap_dss_device .enable()
operation. The latter is called from omap_encoder_enable(), right after
calling omap_encoder_update(). The .set_timings() operation it thus
called twice in a row. Fix it by removing the indirect call.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Laurent Pinchart 2018-06-05 02:06:54 +03:00 committed by Tomi Valkeinen
parent 8fe1d36100
commit bb23800c88
13 changed files with 0 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c
View file

@ -66,8 +66,6 @@ static int tvc_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

3
drivers/gpu/drm/omapdrm/displays/connector-dvi.c
View file

@ -69,7 +69,6 @@ static void dvic_disconnect(struct omap_dss_device *src,
static int dvic_enable(struct omap_dss_device *dssdev)
{
struct panel_drv_data *ddata = to_panel_data(dssdev);
struct omap_dss_device *src = dssdev->src;
int r;
@ -79,8 +78,6 @@ static int dvic_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

2
drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
View file

@ -71,8 +71,6 @@ static int hdmic_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

2
drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
View file

@ -57,8 +57,6 @@ static int opa362_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

2
drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
View file

@ -50,8 +50,6 @@ static int tfp410_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

3
drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
View file

@ -66,15 +66,12 @@ static void tpd_disconnect(struct omap_dss_device *src,
static int tpd_enable(struct omap_dss_device *dssdev)
{
struct panel_drv_data *ddata = to_panel_data(dssdev);
struct omap_dss_device *src = dssdev->src;
int r;
if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

2
drivers/gpu/drm/omapdrm/displays/panel-dpi.c
View file

@ -57,8 +57,6 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

2
drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
View file

@ -142,8 +142,6 @@ static int lb035q02_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

2
drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
View file

@ -132,8 +132,6 @@ static int nec_8048_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

2
drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
View file

@ -80,8 +80,6 @@ static int sharp_ls_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
if (ddata->vcc) {
r = regulator_enable(ddata->vcc);
if (r != 0)

2
drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
View file

@ -523,8 +523,6 @@ static int acx565akm_panel_power_on(struct omap_dss_device *dssdev)
dev_dbg(&ddata->spi->dev, "%s\n", __func__);
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r) {
pr_err("%s sdi enable failed\n", __func__);

2
drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
View file

@ -187,8 +187,6 @@ static int td028ttec1_panel_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;

2
drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
View file

@ -338,8 +338,6 @@ static int tpo_td043_enable(struct omap_dss_device *dssdev)
if (omapdss_device_is_enabled(dssdev))
return 0;
src->ops->set_timings(src, &ddata->vm);
r = src->ops->enable(src);
if (r)
return r;