mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
i2c: sprd: Validate the return value of clock initialization
The 'enable' clock of I2C master is required, we should return an error if failed to get the 'enable' clock, to make sure the I2C driver can be defer probe if the clock resource is not ready. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
parent
3c2588fab6
commit
bbeb6b6c07
1 changed files with 7 additions and 4 deletions
|
@ -466,9 +466,9 @@ static int sprd_i2c_clk_init(struct sprd_i2c *i2c_dev)
|
|||
|
||||
i2c_dev->clk = devm_clk_get(i2c_dev->dev, "enable");
|
||||
if (IS_ERR(i2c_dev->clk)) {
|
||||
dev_warn(i2c_dev->dev, "i2c%d can't get the enable clock\n",
|
||||
i2c_dev->adap.nr);
|
||||
i2c_dev->clk = NULL;
|
||||
dev_err(i2c_dev->dev, "i2c%d can't get the enable clock\n",
|
||||
i2c_dev->adap.nr);
|
||||
return PTR_ERR(i2c_dev->clk);
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
@ -519,7 +519,10 @@ static int sprd_i2c_probe(struct platform_device *pdev)
|
|||
if (i2c_dev->bus_freq != 100000 && i2c_dev->bus_freq != 400000)
|
||||
return -EINVAL;
|
||||
|
||||
sprd_i2c_clk_init(i2c_dev);
|
||||
ret = sprd_i2c_clk_init(i2c_dev);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
platform_set_drvdata(pdev, i2c_dev);
|
||||
|
||||
ret = clk_prepare_enable(i2c_dev->clk);
|
||||
|
|
Loading…
Reference in a new issue