mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 02:19:51 +00:00
openvswitch: Remove incorrect WARN_ONCE().
ovs_ct_find_existing() issues a warning if an existing conntrack entry
classified as IP_CT_NEW is found, with the premise that this should
not happen. However, a newly confirmed, non-expected conntrack entry
remains IP_CT_NEW as long as no reply direction traffic is seen. This
has resulted into somewhat confusing kernel log messages. This patch
removes this check and warning.
Fixes: 289f2253
("openvswitch: Find existing conntrack entry after upcall.")
Suggested-by: Joe Stringer <joe@ovn.org>
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Joe Stringer <joe@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
bf0f500bd0
commit
bce91f8a42
1 changed files with 1 additions and 7 deletions
|
@ -433,7 +433,6 @@ ovs_ct_find_existing(struct net *net, const struct nf_conntrack_zone *zone,
|
|||
struct nf_conntrack_l4proto *l4proto;
|
||||
struct nf_conntrack_tuple tuple;
|
||||
struct nf_conntrack_tuple_hash *h;
|
||||
enum ip_conntrack_info ctinfo;
|
||||
struct nf_conn *ct;
|
||||
unsigned int dataoff;
|
||||
u8 protonum;
|
||||
|
@ -458,13 +457,8 @@ ovs_ct_find_existing(struct net *net, const struct nf_conntrack_zone *zone,
|
|||
|
||||
ct = nf_ct_tuplehash_to_ctrack(h);
|
||||
|
||||
ctinfo = ovs_ct_get_info(h);
|
||||
if (ctinfo == IP_CT_NEW) {
|
||||
/* This should not happen. */
|
||||
WARN_ONCE(1, "ovs_ct_find_existing: new packet for %p\n", ct);
|
||||
}
|
||||
skb->nfct = &ct->ct_general;
|
||||
skb->nfctinfo = ctinfo;
|
||||
skb->nfctinfo = ovs_ct_get_info(h);
|
||||
return ct;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue