mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
Avoid possible NULL pointer deref in 3c359 driver
In xl_freemem(), if dev_if is NULL, the line struct xl_private *xl_priv =(struct xl_private *)dev->priv; will cause a NULL pointer dereference. (akpm: don't try to fix it: just delete the pointless test-for-null) Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
parent
0da18e3883
commit
bcfef8c368
1 changed files with 0 additions and 5 deletions
|
@ -1045,11 +1045,6 @@ static irqreturn_t xl_interrupt(int irq, void *dev_id)
|
|||
u8 __iomem * xl_mmio = xl_priv->xl_mmio ;
|
||||
u16 intstatus, macstatus ;
|
||||
|
||||
if (!dev) {
|
||||
printk(KERN_WARNING "Device structure dead, aaahhhh !\n") ;
|
||||
return IRQ_NONE;
|
||||
}
|
||||
|
||||
intstatus = readw(xl_mmio + MMIO_INTSTATUS) ;
|
||||
|
||||
if (!(intstatus & 1)) /* We didn't generate the interrupt */
|
||||
|
|
Loading…
Reference in a new issue