mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 03:10:12 +00:00
scsi: be2iscsi: Remove redundant iscsi_wrb desc memset
alloc_wrb_handle already does memset zero of iscsi_wrb descriptor so remove redundant memset in WRB submission paths. Add pwrb_handle NULL check before memsett'ing pwrb. Signed-off-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
deeea8edc7
commit
bf9b7554f4
2 changed files with 3 additions and 5 deletions
|
@ -967,7 +967,9 @@ beiscsi_get_wrb_handle(struct hwi_wrb_context *pwrb_context,
|
|||
else
|
||||
pwrb_context->alloc_index++;
|
||||
spin_unlock_bh(&pwrb_context->wrb_lock);
|
||||
memset(pwrb_handle->pwrb, 0, sizeof(*pwrb_handle->pwrb));
|
||||
|
||||
if (pwrb_handle)
|
||||
memset(pwrb_handle->pwrb, 0, sizeof(*pwrb_handle->pwrb));
|
||||
|
||||
return pwrb_handle;
|
||||
}
|
||||
|
@ -4718,7 +4720,6 @@ static int beiscsi_mtask(struct iscsi_task *task)
|
|||
|
||||
cid = beiscsi_conn->beiscsi_conn_cid;
|
||||
pwrb = io_task->pwrb_handle->pwrb;
|
||||
memset(pwrb, 0, sizeof(*pwrb));
|
||||
|
||||
if (is_chip_be2_be3r(phba)) {
|
||||
AMAP_SET_BITS(struct amap_iscsi_wrb, cmdsn_itt, pwrb,
|
||||
|
|
|
@ -1350,7 +1350,6 @@ void beiscsi_offload_cxn_v0(struct beiscsi_offload_params *params,
|
|||
{
|
||||
struct iscsi_wrb *pwrb = pwrb_handle->pwrb;
|
||||
|
||||
memset(pwrb, 0, sizeof(*pwrb));
|
||||
AMAP_SET_BITS(struct amap_iscsi_target_context_update_wrb,
|
||||
max_send_data_segment_length, pwrb,
|
||||
params->dw[offsetof(struct amap_beiscsi_offload_params,
|
||||
|
@ -1422,8 +1421,6 @@ void beiscsi_offload_cxn_v2(struct beiscsi_offload_params *params,
|
|||
{
|
||||
struct iscsi_wrb *pwrb = pwrb_handle->pwrb;
|
||||
|
||||
memset(pwrb, 0, sizeof(*pwrb));
|
||||
|
||||
AMAP_SET_BITS(struct amap_iscsi_target_context_update_wrb_v2,
|
||||
max_burst_length, pwrb, params->dw[offsetof
|
||||
(struct amap_beiscsi_offload_params,
|
||||
|
|
Loading…
Reference in a new issue