mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
perf tools: Fix misleading add event PMU debug message
[ Upstream commitf034fc50d3
] Fix incorrect debug message: Attempting to add event pmu 'intel_pt' with '' that may result in non-fatal errors which always appears with perf record -vv and intel_pt e.g. perf record -vv -e intel_pt//u uname The message is incorrect because there will never be non-fatal errors. Suppress the message if the PMU is 'selectable' i.e. meant to be selected directly as an event. Fixes:4ac22b484d
("perf parse-events: Make add PMU verbose output clearer") Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Jiri Olsa <jolsa@kernel.org> Link: http://lore.kernel.org/lkml/20220411061758.2458417-1-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
280f721edc
commit
bfba9722cf
1 changed files with 3 additions and 2 deletions
|
@ -1442,7 +1442,9 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
|
|||
bool use_uncore_alias;
|
||||
LIST_HEAD(config_terms);
|
||||
|
||||
if (verbose > 1) {
|
||||
pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
|
||||
|
||||
if (verbose > 1 && !(pmu && pmu->selectable)) {
|
||||
fprintf(stderr, "Attempting to add event pmu '%s' with '",
|
||||
name);
|
||||
if (head_config) {
|
||||
|
@ -1455,7 +1457,6 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
|
|||
fprintf(stderr, "' that may result in non-fatal errors\n");
|
||||
}
|
||||
|
||||
pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
|
||||
if (!pmu) {
|
||||
char *err_str;
|
||||
|
||||
|
|
Loading…
Reference in a new issue