mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
[SCSI] qlogicfas: Close narrow race in release
We were releasing the IRQ before removing the host, so commands could still be coming in which would never be seen by the interrupt handler. Just remove the host before releasing the IRQ to close this race. Signed-off-by: Matthew Wilcox <matthew@wil.cx> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
This commit is contained in:
parent
1bd4057346
commit
c131993b4c
1 changed files with 1 additions and 1 deletions
|
@ -166,6 +166,7 @@ static int qlogicfas_release(struct Scsi_Host *shost)
|
|||
{
|
||||
struct qlogicfas408_priv *priv = get_priv_by_host(shost);
|
||||
|
||||
scsi_remove_host(shost);
|
||||
if (shost->irq) {
|
||||
qlogicfas408_disable_ints(priv);
|
||||
free_irq(shost->irq, shost);
|
||||
|
@ -174,7 +175,6 @@ static int qlogicfas_release(struct Scsi_Host *shost)
|
|||
free_dma(shost->dma_channel);
|
||||
if (shost->io_port && shost->n_io_port)
|
||||
release_region(shost->io_port, shost->n_io_port);
|
||||
scsi_remove_host(shost);
|
||||
scsi_host_put(shost);
|
||||
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue