mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 05:12:49 +00:00
netfilter: nf_tables: add missing ->release_ops() in error path of newrule()
[ Upstream commitb25a31bf0c
] ->release_ops() callback releases resources and this is used in error path. If nf_tables_newrule() fails after ->select_ops(), it should release resources. but it can not call ->destroy() because that should be called after ->init(). At this point, ->release_ops() should be used for releasing resources. Test commands: modprobe -rv xt_tcpudp iptables-nft -I INPUT -m tcp <-- error command lsmod Result: Module Size Used by xt_tcpudp 20480 2 <-- it should be 0 Fixes:b8e2040063
("netfilter: nft_compat: use .release_ops and remove list of extension") Signed-off-by: Taehee Yoo <ap420073@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
This commit is contained in:
parent
5014aa9374
commit
c18731c278
1 changed files with 4 additions and 1 deletions
|
@ -2719,8 +2719,11 @@ static int nf_tables_newrule(struct net *net, struct sock *nlsk,
|
|||
nf_tables_rule_release(&ctx, rule);
|
||||
err1:
|
||||
for (i = 0; i < n; i++) {
|
||||
if (info[i].ops != NULL)
|
||||
if (info[i].ops) {
|
||||
module_put(info[i].ops->type->owner);
|
||||
if (info[i].ops->type->release_ops)
|
||||
info[i].ops->type->release_ops(info[i].ops);
|
||||
}
|
||||
}
|
||||
kvfree(info);
|
||||
return err;
|
||||
|
|
Loading…
Reference in a new issue