mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-04 08:08:54 +00:00
ALSA: firewire-lib: fix invalid assignment to union data for directional parameter
[ Upstream commit8304cf77c9
] Although the value of FDF is used just for outgoing stream, the assignment to union member is done for both directions of stream. At present this causes no issue because the value of same position is reassigned later for opposite stream. However, it's better to add if statement. Fixes:d3d10a4a1b
("ALSA: firewire-lib: use union for directional parameters") Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Link: https://lore.kernel.org/r/20200508043635.349339-2-o-takashi@sakamocchi.jp Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
3201bb03c8
commit
c1bcf01aea
1 changed files with 2 additions and 1 deletions
|
@ -82,7 +82,8 @@ int amdtp_am824_set_parameters(struct amdtp_stream *s, unsigned int rate,
|
|||
if (err < 0)
|
||||
return err;
|
||||
|
||||
s->ctx_data.rx.fdf = AMDTP_FDF_AM824 | s->sfc;
|
||||
if (s->direction == AMDTP_OUT_STREAM)
|
||||
s->ctx_data.rx.fdf = AMDTP_FDF_AM824 | s->sfc;
|
||||
|
||||
p->pcm_channels = pcm_channels;
|
||||
p->midi_ports = midi_ports;
|
||||
|
|
Loading…
Reference in a new issue