mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 10:29:37 +00:00
b43legacy: fix a lower bounds test
The problem is that "channel" is an unsigned int, when it's less 5 the
value of "channel - 5" is not a negative number as one would expect but
is very high positive value instead.
This means that "start" becomes a very high positive value. The result
of that is that we never enter the "for (i = start; i <= end; i++) {"
loop. Instead of storing the result from b43legacy_radio_aci_detect()
it just uses zero.
Fixes: 75388acd0c
("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Büsch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211006073542.GD8404@kili
This commit is contained in:
parent
0182d0788c
commit
c1c8380b03
1 changed files with 1 additions and 1 deletions
|
@ -283,7 +283,7 @@ u8 b43legacy_radio_aci_scan(struct b43legacy_wldev *dev)
|
|||
& 0x7FFF);
|
||||
b43legacy_set_all_gains(dev, 3, 8, 1);
|
||||
|
||||
start = (channel - 5 > 0) ? channel - 5 : 1;
|
||||
start = (channel > 5) ? channel - 5 : 1;
|
||||
end = (channel + 5 < 14) ? channel + 5 : 13;
|
||||
|
||||
for (i = start; i <= end; i++) {
|
||||
|
|
Loading…
Reference in a new issue