mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-24 09:50:04 +00:00
Code Issues Releases Wiki Activity

cfq-iosched: do cleanup

Browse source 
Some functions should return boolean.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
This commit is contained in:
Shaohua Li 2010-11-08 15:01:02 +01:00 committed by Jens Axboe
parent f6f94e2ab1
commit c1e44756fd
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
block/cfq-iosched.c
View file

@ -637,11 +637,11 @@ cfq_set_prio_slice(struct cfq_data *cfqd, struct cfq_queue *cfqq)
static inline bool cfq_slice_used(struct cfq_queue *cfqq) static inline bool cfq_slice_used(struct cfq_queue *cfqq)
{ {
if (cfq_cfqq_slice_new(cfqq)) if (cfq_cfqq_slice_new(cfqq))
return 0; return false;
if (time_before(jiffies, cfqq->slice_end)) if (time_before(jiffies, cfqq->slice_end))
return 0; return false;
return 1; return true;
} }
/* /*
@ -1892,10 +1892,10 @@ static bool cfq_should_idle(struct cfq_data *cfqd, struct cfq_queue *cfqq)
* in their service tree. * in their service tree.
*/ */
if (service_tree->count == 1 && cfq_cfqq_sync(cfqq)) if (service_tree->count == 1 && cfq_cfqq_sync(cfqq))
return 1; return true;
cfq_log_cfqq(cfqd, cfqq, "Not idling. st->count:%d", cfq_log_cfqq(cfqd, cfqq, "Not idling. st->count:%d",
service_tree->count); service_tree->count);
return 0; return false;
} }
static void cfq_arm_slice_timer(struct cfq_data *cfqd) static void cfq_arm_slice_timer(struct cfq_data *cfqd)
@ -2359,12 +2359,12 @@ static inline bool cfq_slice_used_soon(struct cfq_data *cfqd,
{ {
/* the queue hasn't finished any request, can't estimate */ /* the queue hasn't finished any request, can't estimate */
if (cfq_cfqq_slice_new(cfqq)) if (cfq_cfqq_slice_new(cfqq))
return 1; return true;
if (time_after(jiffies + cfqd->cfq_slice_idle * cfqq->dispatched, if (time_after(jiffies + cfqd->cfq_slice_idle * cfqq->dispatched,
cfqq->slice_end)) cfqq->slice_end))
return 1; return true;
return 0; return false;
} }
static bool cfq_may_dispatch(struct cfq_data *cfqd, struct cfq_queue *cfqq) static bool cfq_may_dispatch(struct cfq_data *cfqd, struct cfq_queue *cfqq)