mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-26 04:16:39 +00:00
Revert "perf report: Append inlines to non-DWARF callchains"
commitc0b067588a
upstream. This reverts commit46d21ec067
. The tests were made with a specific workload, further tests on a recently updated fedora 38 system with a system wide perf.data file shows 'perf report' taking excessive time resolving inlines in vmlinux, so lets revert this until a full investigation and improvement on the addr2line support code is made. Reported-by: Jesper Dangaard Brouer <hawk@kernel.org> Acked-by: Artem Savkov <asavkov@redhat.com> Tested-by: Jesper Dangaard Brouer <hawk@kernel.org> Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Milian Wolff <milian.wolff@kdab.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: https://lore.kernel.org/r/ZMl8VyhdwhClTM5g@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
5b62847596
commit
c1fc26cc66
1 changed files with 0 additions and 5 deletions
|
@ -44,7 +44,6 @@
|
|||
#include <linux/zalloc.h>
|
||||
|
||||
static void __machine__remove_thread(struct machine *machine, struct thread *th, bool lock);
|
||||
static int append_inlines(struct callchain_cursor *cursor, struct map_symbol *ms, u64 ip);
|
||||
|
||||
static struct dso *machine__kernel_dso(struct machine *machine)
|
||||
{
|
||||
|
@ -2371,10 +2370,6 @@ static int add_callchain_ip(struct thread *thread,
|
|||
ms.maps = al.maps;
|
||||
ms.map = al.map;
|
||||
ms.sym = al.sym;
|
||||
|
||||
if (!branch && append_inlines(cursor, &ms, ip) == 0)
|
||||
return 0;
|
||||
|
||||
srcline = callchain_srcline(&ms, al.addr);
|
||||
err = callchain_cursor_append(cursor, ip, &ms,
|
||||
branch, flags, nr_loop_iter,
|
||||
|
|
Loading…
Reference in a new issue