mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-04 16:15:11 +00:00
kprobes: Limit max data_size of the kretprobe instances
commit6bbfa44116
upstream. The 'kprobe::data_size' is unsigned, thus it can not be negative. But if user sets it enough big number (e.g. (size_t)-8), the result of 'data_size + sizeof(struct kretprobe_instance)' becomes smaller than sizeof(struct kretprobe_instance) or zero. In result, the kretprobe_instance are allocated without enough memory, and kretprobe accesses outside of allocated memory. To avoid this issue, introduce a max limitation of the kretprobe::data_size. 4KB per instance should be OK. Link: https://lkml.kernel.org/r/163836995040.432120.10322772773821182925.stgit@devnote2 Cc: stable@vger.kernel.org Fixes:f47cd9b553
("kprobes: kretprobe user entry-handler") Reported-by: zhangyue <zhangyue1@kylinos.cn> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
2a74c13dfe
commit
c200721f8e
2 changed files with 5 additions and 0 deletions
|
@ -155,6 +155,8 @@ struct kretprobe {
|
|||
raw_spinlock_t lock;
|
||||
};
|
||||
|
||||
#define KRETPROBE_MAX_DATA_SIZE 4096
|
||||
|
||||
struct kretprobe_instance {
|
||||
union {
|
||||
struct hlist_node hlist;
|
||||
|
|
|
@ -2137,6 +2137,9 @@ int register_kretprobe(struct kretprobe *rp)
|
|||
}
|
||||
}
|
||||
|
||||
if (rp->data_size > KRETPROBE_MAX_DATA_SIZE)
|
||||
return -E2BIG;
|
||||
|
||||
rp->kp.pre_handler = pre_handler_kretprobe;
|
||||
rp->kp.post_handler = NULL;
|
||||
rp->kp.fault_handler = NULL;
|
||||
|
|
Loading…
Reference in a new issue