ext2: Remove GFP_NOFS use in ext2_xattr_cache_insert()

ext2_xattr_cache_insert() calls mb_cache_entry_create() with GFP_NOFS
because it is called under EXT2_I(inode)->xattr_sem. However xattr_sem
or any higher ranking lock is not acquired on fs reclaim path for ext2
at least since we don't do page writeback from direct reclaim.  Thus
GFP_NOFS is not needed.

Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Jan Kara 2024-01-09 12:27:44 +01:00
parent 36975616ea
commit c3e637c7f0

View file

@ -874,7 +874,7 @@ ext2_xattr_cache_insert(struct mb_cache *cache, struct buffer_head *bh)
__u32 hash = le32_to_cpu(HDR(bh)->h_hash); __u32 hash = le32_to_cpu(HDR(bh)->h_hash);
int error; int error;
error = mb_cache_entry_create(cache, GFP_NOFS, hash, bh->b_blocknr, error = mb_cache_entry_create(cache, GFP_KERNEL, hash, bh->b_blocknr,
true); true);
if (error) { if (error) {
if (error == -EBUSY) { if (error == -EBUSY) {