mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-12 21:57:43 +00:00
Code Issues Releases Wiki Activity

counter/counter-sysfs: use sysfs_emit everywhere

Browse source 
In the counter subsystem, we are already using sysfs_emit(), but there
were a few places where we were still using sprintf() in *_show()
functions. For consistency and added protections, use sysfs_emit()
everywhere.

Suggested-by: Greg KH <gregkh@linuxfoundation.org>
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Signed-off-by: David Lechner <david@lechnology.com>
Link: https://lore.kernel.org/r/20211017190106.3472645-1-david@lechnology.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Lechner 2021-10-17 14:01:06 -05:00 committed by Greg Kroah-Hartman
parent 15c9a35909
commit c3ed761c9e
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/counter/counter-sysfs.c
View file

@ -113,7 +113,7 @@ static ssize_t counter_comp_u8_show(struct device *dev,
/* data should already be boolean but ensure just to be safe */
data = !!data;
return sprintf(buf, "%u\n", (unsigned int)data);
return sysfs_emit(buf, "%u\n", (unsigned int)data);
}
static ssize_t counter_comp_u8_store(struct device *dev,
@ -196,7 +196,7 @@ static ssize_t counter_comp_u32_show(struct device *dev,
case COUNTER_COMP_COUNT_MODE:
return sysfs_emit(buf, "%s\n", counter_count_mode_str[data]);
default:
return sprintf(buf, "%u\n", (unsigned int)data);
return sysfs_emit(buf, "%u\n", (unsigned int)data);
}
}
@ -300,7 +300,7 @@ static ssize_t counter_comp_u64_show(struct device *dev,
if (err < 0)
return err;
return sprintf(buf, "%llu\n", (unsigned long long)data);
return sysfs_emit(buf, "%llu\n", (unsigned long long)data);
}
static ssize_t counter_comp_u64_store(struct device *dev,
@ -539,7 +539,7 @@ static ssize_t counter_comp_id_show(struct device *dev,
{
const size_t id = (size_t)to_counter_attribute(attr)->comp.priv;
return sprintf(buf, "%zu\n", id);
return sysfs_emit(buf, "%zu\n", id);
}
static int counter_comp_id_attr_create(struct device *const dev,