mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-02 15:18:19 +00:00
Code Issues Releases Wiki Activity

gpio: pca953x: Utilise dev_err_probe() where it makes sense

Browse source 
At least in pca953x_irq_setup() we may use dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Andy Shevchenko 2023-09-01 16:40:34 +03:00 committed by Bartosz Golaszewski
parent 53c59d66c4
commit c47f7ff0fe
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/gpio/gpio-pca953x.c
View file

@ -926,6 +926,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)
static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base) static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
{ {
struct i2c_client *client = chip->client; struct i2c_client *client = chip->client;
struct device *dev = &client->dev;
DECLARE_BITMAP(reg_direction, MAX_LINE); DECLARE_BITMAP(reg_direction, MAX_LINE);
DECLARE_BITMAP(irq_stat, MAX_LINE); DECLARE_BITMAP(irq_stat, MAX_LINE);
struct gpio_irq_chip *girq; struct gpio_irq_chip *girq;
@ -974,11 +975,8 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
NULL, pca953x_irq_handler, NULL, pca953x_irq_handler,
IRQF_ONESHOT | IRQF_SHARED, IRQF_ONESHOT | IRQF_SHARED,
dev_name(&client->dev), chip); dev_name(&client->dev), chip);
if (ret) { if (ret)
dev_err(&client->dev, "failed to request irq %d\n", return dev_err_probe(dev, client->irq, "failed to request irq\n");
client->irq);
return ret;
}
return 0; return 0;
} }