mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
ax25: fix use-after-free bugs caused by ax25_ds_del_timer
commitfd819ad3ec
upstream. When the ax25 device is detaching, the ax25_dev_device_down() calls ax25_ds_del_timer() to cleanup the slave_timer. When the timer handler is running, the ax25_ds_del_timer() that calls del_timer() in it will return directly. As a result, the use-after-free bugs could happen, one of the scenarios is shown below: (Thread 1) | (Thread 2) | ax25_ds_timeout() ax25_dev_device_down() | ax25_ds_del_timer() | del_timer() | ax25_dev_put() //FREE | | ax25_dev-> //USE In order to mitigate bugs, when the device is detaching, use timer_shutdown_sync() to stop the timer. Fixes:1da177e4c3
("Linux-2.6.12-rc2") Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20240329015023.9223-1-duoming@zju.edu.cn Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
fd17771f67
commit
c6a368f9c7
1 changed files with 1 additions and 1 deletions
|
@ -105,7 +105,7 @@ void ax25_dev_device_down(struct net_device *dev)
|
|||
spin_lock_bh(&ax25_dev_lock);
|
||||
|
||||
#ifdef CONFIG_AX25_DAMA_SLAVE
|
||||
ax25_ds_del_timer(ax25_dev);
|
||||
timer_shutdown_sync(&ax25_dev->dama.slave_timer);
|
||||
#endif
|
||||
|
||||
/*
|
||||
|
|
Loading…
Reference in a new issue