mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 21:33:52 +00:00
cxl/region: prevent underflow in ways_to_cxl()
The "ways" variable comes from the user. The ways_to_cxl() function
has an upper bound but it doesn't check for negatives. Make
the "ways" variable an unsigned int to fix this bug.
Fixes: 80d10a6cee
("cxl/region: Add interleave geometry attributes")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Yueo3NV2hFCXx1iV@kili
[djbw: fixup interleave_ways_store() to only accept unsigned input]
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
parent
88ab1dde79
commit
c7e3548cac
2 changed files with 4 additions and 3 deletions
|
@ -319,10 +319,11 @@ static ssize_t interleave_ways_store(struct device *dev,
|
|||
struct cxl_decoder *cxld = &cxlrd->cxlsd.cxld;
|
||||
struct cxl_region *cxlr = to_cxl_region(dev);
|
||||
struct cxl_region_params *p = &cxlr->params;
|
||||
int rc, val, save;
|
||||
unsigned int val, save;
|
||||
int rc;
|
||||
u8 iw;
|
||||
|
||||
rc = kstrtoint(buf, 0, &val);
|
||||
rc = kstrtouint(buf, 0, &val);
|
||||
if (rc)
|
||||
return rc;
|
||||
|
||||
|
|
|
@ -102,7 +102,7 @@ static inline int granularity_to_cxl(int g, u16 *ig)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static inline int ways_to_cxl(int ways, u8 *iw)
|
||||
static inline int ways_to_cxl(unsigned int ways, u8 *iw)
|
||||
{
|
||||
if (ways > 16)
|
||||
return -EINVAL;
|
||||
|
|
Loading…
Reference in a new issue