mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 22:54:01 +00:00
sunrpc: svcauth_gss_register_pseudoflavor must reject duplicate registrations.
commit d47a5dc288
upstream.
There is no valid case for supporting duplicate pseudoflavor
registrations.
Currently the silent acceptance of such registrations is hiding a bug.
The rpcsec_gss_krb5 module registers 2 flavours but does not unregister
them, so if you load, unload, reload the module, it will happily
continue to use the old registration which now has pointers to the
memory were the module was originally loaded. This could lead to
unexpected results.
So disallow duplicate registrations.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=206651
Cc: stable@vger.kernel.org (v2.6.12+)
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
5ec83ff488
commit
c894f31a87
1 changed files with 4 additions and 2 deletions
|
@ -796,9 +796,11 @@ svcauth_gss_register_pseudoflavor(u32 pseudoflavor, char * name)
|
|||
new->h.flavour = &svcauthops_gss;
|
||||
new->pseudoflavor = pseudoflavor;
|
||||
|
||||
stat = 0;
|
||||
test = auth_domain_lookup(name, &new->h);
|
||||
if (test != &new->h) { /* Duplicate registration */
|
||||
if (test != &new->h) {
|
||||
pr_warn("svc: duplicate registration of gss pseudo flavour %s.\n",
|
||||
name);
|
||||
stat = -EADDRINUSE;
|
||||
auth_domain_put(test);
|
||||
kfree(new->h.name);
|
||||
goto out_free_dom;
|
||||
|
|
Loading…
Reference in a new issue