mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 13:22:57 +00:00
mm/damon/schemes: add the validity judgment of thresholds
In dbgfs "schemes" interface, i do some test like this: # cd /sys/kernel/debug/damon # echo "2 1 2 1 10 1 3 10 1 1 1 1 1 1 1 1 2 3" > schemes # cat schemes # 2 1 2 1 10 1 3 10 1 1 1 1 1 1 1 1 2 3 0 0 There have some unreasonable places, i set the valules of these variables "<min_sz, max_sz> <min_nr_a, max_nr_a>, <min_age, max_age>, <wmarks.high, wmarks.mid, wmarks.low>" as "<2, 1>, <2, 1>, <10, 1>, <1, 2, 3>. So there add a validity judgment for these thresholds value. Link: https://lkml.kernel.org/r/d78360e52158d786fcbf20bc62c96785742e76d3.1637239568.git.xhao@linux.alibaba.com Signed-off-by: Xin Hao <xhao@linux.alibaba.com> Reviewed-by: SeongJae Park <sj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
8bd0b9da03
commit
c89ae63eb0
1 changed files with 7 additions and 0 deletions
|
@ -213,6 +213,13 @@ static struct damos **str_to_schemes(const char *str, ssize_t len,
|
||||||
if (!damos_action_valid(action))
|
if (!damos_action_valid(action))
|
||||||
goto fail;
|
goto fail;
|
||||||
|
|
||||||
|
if (min_sz > max_sz || min_nr_a > max_nr_a || min_age > max_age)
|
||||||
|
goto fail;
|
||||||
|
|
||||||
|
if (wmarks.high < wmarks.mid || wmarks.high < wmarks.low ||
|
||||||
|
wmarks.mid < wmarks.low)
|
||||||
|
goto fail;
|
||||||
|
|
||||||
pos += parsed;
|
pos += parsed;
|
||||||
scheme = damon_new_scheme(min_sz, max_sz, min_nr_a, max_nr_a,
|
scheme = damon_new_scheme(min_sz, max_sz, min_nr_a, max_nr_a,
|
||||||
min_age, max_age, action, "a, &wmarks);
|
min_age, max_age, action, "a, &wmarks);
|
||||||
|
|
Loading…
Reference in a new issue