mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
drm/msm: Fix legacy relocs path
In moving code around, we ended up using the same pointer to
copy_from_user() the relocs tables as we used for the cmd table
entry, which is clearly not right. This went unnoticed because
modern mesa on non-ancent kernels does not actually use relocs.
But this broke ancient mesa on modern kernels.
Reported-by: Emil Velikov <emil.velikov@collabora.com>
Fixes: 20224d715a
("drm/msm/submit: Move copy_from_user ahead of locking bos")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Akhil P Oommen <akhilpo@codeaurora.org>
This commit is contained in:
parent
7df222c359
commit
c8d99bb938
1 changed files with 2 additions and 0 deletions
|
@ -198,6 +198,8 @@ static int submit_lookup_cmds(struct msm_gem_submit *submit,
|
|||
submit->cmd[i].idx = submit_cmd.submit_idx;
|
||||
submit->cmd[i].nr_relocs = submit_cmd.nr_relocs;
|
||||
|
||||
userptr = u64_to_user_ptr(submit_cmd.relocs);
|
||||
|
||||
sz = array_size(submit_cmd.nr_relocs,
|
||||
sizeof(struct drm_msm_gem_submit_reloc));
|
||||
/* check for overflow: */
|
||||
|
|
Loading…
Reference in a new issue