mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
ALSA: firewire-lib: Restrict calling flush_context_completion() when context exists
Currently, drivers can bring XRUN state for PCM substreams when error to queue packets or detecting discontinuity of packet. The application may try to recover this state by calling snd_pcm_prepare(). Depending on each driver, .prepare() includes restart streaming. Then there is a state that PCM substreams are running but isochronous contexts are stopped. In this case, when .pointer() is called, it refers to error pointer. This commit is for a prevention of this bug. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
7b2d99fa6b
commit
c8de6dbbbb
1 changed files with 1 additions and 1 deletions
|
@ -898,7 +898,7 @@ EXPORT_SYMBOL(amdtp_stream_start);
|
|||
unsigned long amdtp_stream_pcm_pointer(struct amdtp_stream *s)
|
||||
{
|
||||
/* this optimization is allowed to be racy */
|
||||
if (s->pointer_flush)
|
||||
if (s->pointer_flush && amdtp_stream_running(s))
|
||||
fw_iso_context_flush_completions(s->context);
|
||||
else
|
||||
s->pointer_flush = true;
|
||||
|
|
Loading…
Reference in a new issue