ptp_qoriq: fix memory leak in probe()

[ Upstream commit f33642224e ]

Smatch complains that:
drivers/ptp/ptp_qoriq.c ptp_qoriq_probe()
warn: 'base' from ioremap() not released.

Fix this by revising the parameter from 'ptp_qoriq->base' to 'base'.
This is only a bug if ptp_qoriq_init() returns on the
first -ENODEV error path.
For other error paths ptp_qoriq->base and base are the same.
And this change makes the code more readable.

Fixes: 7f4399ba40 ("ptp_qoriq: fix NULL access if ptp dt node missing")
Signed-off-by: SongJingyi <u201912584@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230324031406.1895159-1-u201912584@hust.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

This commit is contained in:

SongJingyi

2023-03-24 11:14:06 +08:00

committed by

Greg Kroah-Hartman

parent fe668aa499

commit c960785c81

1 changed files with 1 additions and 1 deletions

									
										2

drivers/ptp/ptp_qoriq.c

										View File
									
				@ -601,7 +601,7 @@ static int ptp_qoriq_probe(struct platform_device *dev)

					return 0;

				no_clock:

					iounmap(ptp_qoriq->base);

					iounmap(base);

				no_ioremap:

					release_resource(ptp_qoriq->rsrc);

				no_resource:

ptp_qoriq: fix memory leak in probe()

2 drivers/ptp/ptp_qoriq.c Unescape Escape View File

2

drivers/ptp/ptp_qoriq.c

View File