mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 23:58:05 +00:00
drm/i915/gt: Retire unexpected starting state error dumping
We have not seen an occurrence of the false restart state recenty, and if we did see such an event from inside engine-reset, it would deadlock on trying to suspend the tasklet to read the register state (from inside the tasklet). Instead, we inspect the context state before submission which will alert us to any issues prior to execution on HW. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Cc: Andi Shyti <andi.shyti@intel.com> Reviewed-by: Andi Shyti <andi.shyti@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20210201164222.14455-1-chris@chris-wilson.co.uk Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
parent
8bb92516da
commit
c9a995e5a7
1 changed files with 0 additions and 20 deletions
|
@ -2720,31 +2720,11 @@ static void enable_execlists(struct intel_engine_cs *engine)
|
|||
enable_error_interrupt(engine);
|
||||
}
|
||||
|
||||
static bool unexpected_starting_state(struct intel_engine_cs *engine)
|
||||
{
|
||||
bool unexpected = false;
|
||||
|
||||
if (ENGINE_READ_FW(engine, RING_MI_MODE) & STOP_RING) {
|
||||
drm_dbg(&engine->i915->drm,
|
||||
"STOP_RING still set in RING_MI_MODE\n");
|
||||
unexpected = true;
|
||||
}
|
||||
|
||||
return unexpected;
|
||||
}
|
||||
|
||||
static int execlists_resume(struct intel_engine_cs *engine)
|
||||
{
|
||||
intel_mocs_init_engine(engine);
|
||||
|
||||
intel_breadcrumbs_reset(engine->breadcrumbs);
|
||||
|
||||
if (GEM_SHOW_DEBUG() && unexpected_starting_state(engine)) {
|
||||
struct drm_printer p = drm_debug_printer(__func__);
|
||||
|
||||
intel_engine_dump(engine, &p, NULL);
|
||||
}
|
||||
|
||||
enable_execlists(engine);
|
||||
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue