mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
Char: synclink, remove unnecessary checks
Stanse found a potential null dereference in mgsl_put_char and mgsl_write. There is a check for tty being NULL, but it is dereferenced earlier. Actually, tty cannot be NULL in .write and .put_char, so remove the tests. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
e6c4ef984e
commit
ca1cce49c2
1 changed files with 2 additions and 2 deletions
|
@ -2031,7 +2031,7 @@ static int mgsl_put_char(struct tty_struct *tty, unsigned char ch)
|
|||
if (mgsl_paranoia_check(info, tty->name, "mgsl_put_char"))
|
||||
return 0;
|
||||
|
||||
if (!tty || !info->xmit_buf)
|
||||
if (!info->xmit_buf)
|
||||
return 0;
|
||||
|
||||
spin_lock_irqsave(&info->irq_spinlock, flags);
|
||||
|
@ -2121,7 +2121,7 @@ static int mgsl_write(struct tty_struct * tty,
|
|||
if (mgsl_paranoia_check(info, tty->name, "mgsl_write"))
|
||||
goto cleanup;
|
||||
|
||||
if (!tty || !info->xmit_buf)
|
||||
if (!info->xmit_buf)
|
||||
goto cleanup;
|
||||
|
||||
if ( info->params.mode == MGSL_MODE_HDLC ||
|
||||
|
|
Loading…
Reference in a new issue