mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
SUNRPC: return negative value in case rpcbind client creation error
Without this patch kernel will panic on LockD start, because lockd_up() checks lockd_up_net() result for negative value. From my pow it's better to return negative value from rpcbind routines instead of replacing all such checks like in lockd_up(). Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Cc: stable@vger.kernel.org [>= 3.0]
This commit is contained in:
parent
89d77c8fa8
commit
caea33da89
1 changed files with 2 additions and 2 deletions
|
@ -251,7 +251,7 @@ static int rpcb_create_local_unix(struct net *net)
|
||||||
if (IS_ERR(clnt)) {
|
if (IS_ERR(clnt)) {
|
||||||
dprintk("RPC: failed to create AF_LOCAL rpcbind "
|
dprintk("RPC: failed to create AF_LOCAL rpcbind "
|
||||||
"client (errno %ld).\n", PTR_ERR(clnt));
|
"client (errno %ld).\n", PTR_ERR(clnt));
|
||||||
result = -PTR_ERR(clnt);
|
result = PTR_ERR(clnt);
|
||||||
goto out;
|
goto out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -298,7 +298,7 @@ static int rpcb_create_local_net(struct net *net)
|
||||||
if (IS_ERR(clnt)) {
|
if (IS_ERR(clnt)) {
|
||||||
dprintk("RPC: failed to create local rpcbind "
|
dprintk("RPC: failed to create local rpcbind "
|
||||||
"client (errno %ld).\n", PTR_ERR(clnt));
|
"client (errno %ld).\n", PTR_ERR(clnt));
|
||||||
result = -PTR_ERR(clnt);
|
result = PTR_ERR(clnt);
|
||||||
goto out;
|
goto out;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue