mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 05:44:11 +00:00
brcmfmac: check p2pdev mac address uniqueness
The mac address for p2pdev must be different from the primary interface due to firmware requirement. Add an explicit check for this requirement if user-space provides a mac address. Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com> Reviewed-by: Franky Lin <franky.lin@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
parent
3ea0a58cf9
commit
cb746e4783
1 changed files with 7 additions and 0 deletions
|
@ -2073,6 +2073,13 @@ static struct wireless_dev *brcmf_p2p_create_p2pdev(struct brcmf_p2p_info *p2p,
|
||||||
}
|
}
|
||||||
|
|
||||||
pri_ifp = p2p->bss_idx[P2PAPI_BSSCFG_PRIMARY].vif->ifp;
|
pri_ifp = p2p->bss_idx[P2PAPI_BSSCFG_PRIMARY].vif->ifp;
|
||||||
|
|
||||||
|
/* firmware requires unique mac address for p2pdev interface */
|
||||||
|
if (addr && ether_addr_equal(addr, pri_ifp->mac_addr)) {
|
||||||
|
brcmf_err("discovery vif must be different from primary interface\n");
|
||||||
|
return ERR_PTR(-EINVAL);
|
||||||
|
}
|
||||||
|
|
||||||
brcmf_p2p_generate_bss_mac(p2p, addr);
|
brcmf_p2p_generate_bss_mac(p2p, addr);
|
||||||
brcmf_p2p_set_firmware(pri_ifp, p2p->dev_addr);
|
brcmf_p2p_set_firmware(pri_ifp, p2p->dev_addr);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue