mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-07 00:59:06 +00:00
Code Issues Releases Wiki Activity

staging: tidspbridge: use safer test on the result of find_first_zero_bit

Browse source 
Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may
return a larger number than the maximum position argument if that position
is not a multiple of BITS_PER_LONG.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3;
statement S1,S2;
@@

e1 = find_first_zero_bit(e2,e3)
...
if (e1
- ==
+ >=
  e3)
S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Julia Lawall 2014-06-04 11:07:54 +02:00 committed by Greg Kroah-Hartman
parent cee49b3cfb
commit cc0be81f00
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/tidspbridge/rmgr/node.c
View file

@ -935,7 +935,7 @@ int node_connect(struct node_object *node1, u32 stream1,
node2_type == NODE_DAISSOCKET)) { node2_type == NODE_DAISSOCKET)) {
/* Find available pipe */ /* Find available pipe */
pipe_id = find_first_zero_bit(hnode_mgr->pipe_map, MAXPIPES); pipe_id = find_first_zero_bit(hnode_mgr->pipe_map, MAXPIPES);
if (pipe_id == MAXPIPES) { if (pipe_id >= MAXPIPES) {
status = -ECONNREFUSED; status = -ECONNREFUSED;
goto out_unlock; goto out_unlock;
} }
@ -1008,7 +1008,7 @@ int node_connect(struct node_object *node1, u32 stream1,
status = -EINVAL; status = -EINVAL;
goto out_unlock; goto out_unlock;
} }
if (chnl_id == CHNL_MAXCHANNELS) { if (chnl_id >= CHNL_MAXCHANNELS) {
status = -ECONNREFUSED; status = -ECONNREFUSED;
goto out_unlock; goto out_unlock;
} }