mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 06:10:56 +00:00
Input: tca6416-keypad - fix interrupt enable disbalance
The driver has been switched to use IRQF_NO_AUTOEN, but in the error
unwinding and remove paths calls to enable_irq() were left in place, which
will lead to an incorrect enable counter value.
Fixes: bcd9730a04
("Input: move to use request_irq by IRQF_NO_AUTOEN flag")
Link: https://lore.kernel.org/r/20230724053024.352054-3-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
parent
d3176b2926
commit
cc141c35af
1 changed files with 2 additions and 6 deletions
|
@ -291,10 +291,8 @@ static int tca6416_keypad_probe(struct i2c_client *client)
|
|||
return 0;
|
||||
|
||||
fail2:
|
||||
if (!chip->use_polling) {
|
||||
if (!chip->use_polling)
|
||||
free_irq(client->irq, chip);
|
||||
enable_irq(client->irq);
|
||||
}
|
||||
fail1:
|
||||
input_free_device(input);
|
||||
kfree(chip);
|
||||
|
@ -305,10 +303,8 @@ static void tca6416_keypad_remove(struct i2c_client *client)
|
|||
{
|
||||
struct tca6416_keypad_chip *chip = i2c_get_clientdata(client);
|
||||
|
||||
if (!chip->use_polling) {
|
||||
if (!chip->use_polling)
|
||||
free_irq(client->irq, chip);
|
||||
enable_irq(client->irq);
|
||||
}
|
||||
|
||||
input_unregister_device(chip->input);
|
||||
kfree(chip);
|
||||
|
|
Loading…
Reference in a new issue